Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVE] Close Call contextual bar after starting jitsi call. #21004

Merged
merged 3 commits into from
Mar 4, 2021

Conversation

yash-rajpal
Copy link
Member

  • I have read the Contributing Guide
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

After jitsi call is started, if the call is started in a new window then we should close contextual tab bar.
So, when 'YES' is pressed on modal, we call handleClose function if openNewWindow is true, as call doesn't starts on tab bar, it starts on new window.

Issue(s)

fixes #21003

Steps to test or reproduce

Further comments

fix-jitsi-openBar-after

@yash-rajpal
Copy link
Member Author

@tassoevan @dougfabris Please have a look. Thanks. :)

@tassoevan tassoevan requested a review from a team March 4, 2021 21:50
@tassoevan tassoevan added this to the 3.12.1 milestone Mar 4, 2021
@tassoevan tassoevan merged commit b37feea into RocketChat:develop Mar 4, 2021
@sampaiodiego sampaiodiego mentioned this pull request Mar 5, 2021
sampaiodiego pushed a commit that referenced this pull request Mar 5, 2021
Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>
sampaiodiego pushed a commit that referenced this pull request Mar 8, 2021
Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>
sampaiodiego pushed a commit that referenced this pull request Mar 8, 2021
Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>
vanhoang1107 pushed a commit to vanhoang1107/Rocket.Chat that referenced this pull request Mar 9, 2021
* rocketchat/master:
  Bump version to 3.12.1
  [FIX] Missing spaces on attachment (RocketChat#21020)
  [IMPROVE] Close Call contextual bar after starting Jitsi call (RocketChat#21004)
  [FIX] Stopping Jitsi reload (RocketChat#20973)
gabriellsh added a commit that referenced this pull request Mar 29, 2021
…s/remove_user

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression: When only 'teams' type is provided, show only rooms with teamMain on rooms.adminRooms endpoint (#21322)
  [FIX] 'Chats in Progress' Section is not rendering when the routing algorithm is not Manual Selection (#21324)
  Bump version to 3.12.2
  Bump version to 3.12.1
  [FIX] Missing spaces on attachment (#21020)
  [IMPROVE] Close Call contextual bar after starting Jitsi call (#21004)
  [FIX] Stopping Jitsi reload (#20973)
@TAGHDOUTI
Copy link

Hello please I wonder if we can add jitsi chat conversations in new rocket.chat channels automatically

It's possible ?

@dougfabris
Copy link
Member

Hello please I wonder if we can add jitsi chat conversations in new rocket.chat channels automatically

It's possible ?

@TAGHDOUTI Currently, we don't have this kind of integration with the Jitsi Room's Chat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Call Contextual bar remains open after starting the call
5 participants