Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fixing the changing custom status behavior #24218

Merged
merged 20 commits into from
Jan 24, 2022

Conversation

AllanPazRibeiro
Copy link
Contributor

Proposed changes (including videos or screenshots)

This PR has the following fixes and additions:

  • Fix on the custom status change when it is updated for both App and server
  • Adds the custom status text on the user card tooltip

Issue(s)

Steps to test or reproduce

Further comments

@AllanPazRibeiro AllanPazRibeiro self-assigned this Jan 19, 2022
@AllanPazRibeiro AllanPazRibeiro requested review from juliajforesti, tassoevan and d-gubert and removed request for juliajforesti and tassoevan January 19, 2022 17:49
app/lib/server/functions/setStatus.ts Outdated Show resolved Hide resolved
app/lib/server/functions/setStatus.ts Outdated Show resolved Hide resolved
app/apps/server/bridges/users.ts Outdated Show resolved Hide resolved
app/apps/server/bridges/users.ts Outdated Show resolved Hide resolved
d-gubert
d-gubert previously approved these changes Jan 21, 2022
@d-gubert d-gubert added this to the 4.4.0 milestone Jan 21, 2022
@d-gubert d-gubert merged commit 36aa6f1 into develop Jan 24, 2022
@d-gubert d-gubert deleted the fix/fixing-the-changing-custom-status-behavior branch January 24, 2022 17:38
gabriellsh added a commit that referenced this pull request Jan 25, 2022
…age-template-2

* 'develop' of github.com:RocketChat/Rocket.Chat: (81 commits)
  Language update from LingoHub 🤖 (#24268)
  Regression: Fix incompatibility of apps http requests (#24276)
  [IMPROVE] lib/Statistics improved and metrics collector (#24177)
  [FIX] Fixing the changing custom status behavior (#24218)
  Regression: Align Omni-Source icon sizes with designs (#24269)
  Regression: Fix Inactive Departments still visible on Livechat (#24267)
  [FIX] Solved Report Message Blank (#24262)
  [FIX] Errors on advanced sync prevent LDAP users from logging in (#23958)
  Chore: Convert model LoginServiceConfiguration to raw (#24187)
  [FIX] Make canned responses popup dependent on Canned_responses_enabled setting (#23804)
  [FIX] Wrong german translation for 2FA-Promt (#24126)
  Bump follow-redirects from 1.14.5 to 1.14.7 in /ee/server/services (#24182)
  Chore: Update pino and pino-pretty (#24242)
  [FIX] Avoid updating all rooms with visitor abandonment queries (#24252)
  Add: Alpine image as option for build (#12548)
  Fixed broken links in setup wizard (#24248)
  [FIX] Apps Contextual Bar not carrying title and room information   (#24241)
  Chore: Bump fuselage hooks (#24233)
  Regression: Remove extra call to `useOutsideClick` hook not following the function signature (#24243)
  [FIX] Change canned response model index to match other definition (#24235)
  ...
Comment on lines +98 to +100
const { status } = fields;
delete fields.status;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

	const { status, ...updatedFields } = fields;

	await UsersRaw.update({ _id: user.id }, { $set: updatedFields });

	if (status) {
		UserPresence.setDefaultStatus(user.id, status);
	}

@sampaiodiego sampaiodiego mentioned this pull request Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants