Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVE] Differ Voip calls from Incoming and Outgoing #25643

Merged
merged 23 commits into from
Jun 27, 2022
Merged

[IMPROVE] Differ Voip calls from Incoming and Outgoing #25643

merged 23 commits into from
Jun 27, 2022

Conversation

murtaza98
Copy link
Contributor

@murtaza98 murtaza98 commented May 26, 2022 •
edited
Loading

Proposed changes (including videos or screenshots)

Updated this column and its respective endpoints to support inbound/outfound call definitions
image

Issue(s)

Steps to test or reproduce

Further comments

Clickup: https://app.clickup.com/t/22bmc0f

@murtaza98 murtaza98 requested review from a team as code owners May 26, 2022 14:43
@murtaza98 murtaza98 requested a review from a team May 26, 2022 14:43
@KevLehman
Copy link
Contributor

The pipe fails, and seems like an actual fail 👀 can you take a look?

KevLehman
KevLehman reviewed May 26, 2022
View reviewed changes
Copy link
Contributor

@KevLehman KevLehman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls check if voip/rooms endpoint can be filtered by the new prop too :)

apps/meteor/app/api/server/v1/voip/rooms.ts Outdated Show resolved Hide resolved
@murtaza98 murtaza98 requested a review from tiagoevanp May 27, 2022 06:19
@murtaza98
Copy link
Contributor Author

Pls check if voip/rooms endpoint can be filtered by the new prop too :)

Alright! Added a new parameter there too, allowing filter by call direction

@murtaza98 murtaza98 dismissed tiagoevanp’s stale review May 30, 2022 06:22

Applied the type suggestions. Thanks Tiago :)

KevLehman
KevLehman previously approved these changes May 30, 2022
View reviewed changes
apps/meteor/app/api/server/v1/voip/rooms.ts Outdated Show resolved Hide resolved
@KevLehman KevLehman dismissed their stale review May 30, 2022 18:55

Didn't mean to approve :(

@murtaza98 murtaza98 force-pushed the voip/ib_ob branch 3 times, most recently from 5d8592d to d332b81 Compare June 6, 2022 10:43
@KevLehman
Copy link
Contributor

Conflicts 😬

@murtaza98
Copy link
Contributor Author

Conflicts grimacing

Fixed it 👍

@KevLehman
Copy link
Contributor

New conflicts 😬

@murtaza98
Copy link
Contributor Author

New conflicts grimacing

Haha... lots of changes happening here which is great!! Fixed the conflicts btw

@murtaza98 murtaza98 added this to the 5.0.0 milestone Jun 24, 2022
KevLehman
KevLehman previously approved these changes Jun 27, 2022
View reviewed changes
@KevLehman KevLehman added stat: QA skipped stat: ready to merge PR tested and approved waiting for merge labels Jun 27, 2022
@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Jun 27, 2022
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Jun 27, 2022

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@github-actions github-actions bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jun 27, 2022
@ggazzo
Copy link
Member

ggazzo commented Jun 27, 2022

I can't see why we are skipping QA for this task

@KevLehman
Copy link
Contributor

I can't see why we are skipping QA for this task

This can't be tested as it's BE mostly, and will be tested in another task

@KevLehman KevLehman added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jun 27, 2022
@kodiakhq kodiakhq bot merged commit acdb7f9 into develop Jun 27, 2022
@kodiakhq kodiakhq bot deleted the voip/ib_ob branch June 27, 2022 19:40
gabriellsh added a commit that referenced this pull request Jun 28, 2022
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into impr…
4c2a571 
…ove/message-renderer-tweaks

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [NEW] Enable outbound calling for EE (#25843) (#25960)
  Chore: Introduce new index to query active livechat conversations for cloud scaling (#26047)
  [FIX] Importer fails to download files from URLs with query string params (#25934)
  [IMPROVE] Moved call hold/unhold to EE (#26007)
  [NEW] Engagement Metrics - Phase 2 (#25505)
  Chore: Convert usePreventDefault, useQueryOptions, useShortcutOpenMenu (#26035)
  [FIX] Importer files are unnecessarily transferred over the network. (#25919)
  Chore: test turbo params (#26038)
  Chore: Create a token for each action (#26023)
  Chore: Migrate oembed to ts (#25622)
  Regression: Fix voip call wrap-up model not working (#26024)
  Chore: Updating Apps-Engine  (#26001)
  [IMPROVE] Differ Voip calls from Incoming and Outgoing (#25643)
  [FIX] Append path To Route For Custom Emoji (#24379)
  [IMPROVE] Moved call wrap up modal to EE (#25875)
  Chore: Major refactors in pageobjects (#26015)
@murtaza98 murtaza98 mentioned this pull request Jul 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

@KevLehman KevLehman KevLehman approved these changes

@tiagoevanp tiagoevanp tiagoevanp approved these changes

@aleksandernsilva aleksandernsilva aleksandernsilva left review comments

Assignees
No one assigned
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@murtaza98 @KevLehman @ggazzo @aleksandernsilva @sampaiodiego @tiagoevanp