[NEW] Enable outbound calling for EE #25843

amolghode1981 · 2022-06-13T13:34:39Z

Proposed changes (including videos or screenshots)

Adding structure for supporting EE features for Voip client. This PR handles making outbound calls.

Issue(s)

Steps to test or reproduce

Further comments

Description: Creating EE structure for outbound dialing. Refactored VoIPUser.ts and made necessary fields protected. Created VoIPUser or EEVoipClient based on the licensing in SimpleVoipUser Made necessary changes for using the voip client.

Description: Adding missing file.

…oundcall

Description: Connector changes for detecting the outbound call.

apps/meteor/client/lib/voip/VoIPUser.ts

KevLehman · 2022-06-13T15:26:00Z

apps/meteor/client/providers/CallProvider/CallProvider.tsx

+
+	const createRoom = useCallback(
+		async (caller: ICallerInfo): Promise<IVoipRoom['_id']> => {
+			if (user) {


if (!user) return '' to avoid nesting

KevLehman · 2022-06-14T03:50:40Z

apps/meteor/client/lib/voip/VoIPUser.ts

 					this.setupRemoteMedia();
-					this.emit('callestablished');
+					this._callState = 'IN_CALL';


Even if the if is used, this will override the answer_received _callState. Is that expected?

This would not matter. The problem is there is no chance for the system to receive 2 states. i.e ANSWER_RECEIVED and IN_CALL for outbound call. I am setting it there assuming between the statements this._callState = 'ANSWER_RECEIVED'; and this._callState = 'IN_CALL'; if there is any async call happens, the _callstate should be consistent.

But for now, it does not matter as sip.js does not give us any callback when remote answer is received. (When remote answer is received and correct, there is just of formality of sending ACK. the call and media has already establised. But sematically they are 2 different states).

KevLehman · 2022-06-14T03:51:45Z

apps/meteor/client/providers/CallProvider/CallProvider.tsx

+				return;
+			}
+			stopRingback();
+			if (callDetails.userState === UserState.UAC) {


Suggested change

if (callDetails.userState === UserState.UAC) {

if (callDetails.userState !== UserState.UAC) { return }

To avoid nesting

KevLehman · 2022-06-14T03:56:46Z

apps/meteor/client/providers/CallProvider/CallProvider.tsx

+		if (!result.voipClient) {
+			return;
+		}
+		if (!user) {
+			return;
+		}


Suggested change

if (!result.voipClient) {

return;

}

if (!user) {

return;

}

if (!result.voipClient || !user || result.voipClient.userState !== UserState.UAC) {

return;

}

result.voipClient.userState will not be a part of this if. Even if the voipClient.userState !== UAC, we do want to stop the ringback.
It will be just
if (!result.voipClient || !callDetails.callInfo) {
return;
}

KevLehman · 2022-06-14T03:57:22Z

apps/meteor/client/providers/CallProvider/CallProvider.tsx

+		if (result.voipClient.userState === UserState.UAC) {
+			startRingback(user);
+		}


Suggested change

if (result.voipClient.userState === UserState.UAC) {

startRingback(user);

}

startRingback(user);

apps/meteor/client/lib/voip/VoIPUser.ts

apps/meteor/ee/client/lib/voip/EEVoipClient.ts

Description: Handling review comments.

murtaza98

It looks good to me but I'll leave the final approval to the Frontend guys :)

…oundcall

tiagoevanp · 2022-06-21T17:53:36Z

apps/meteor/client/lib/voip/SimpleVoipUser.ts

@@ -24,7 +26,9 @@ export class SimpleVoipUser {
 			connectionRetryCount: voipRetryCount,
 			enableKeepAliveUsingOptionsForUnstableNetworks: enableKeepAliveForUnstableNetworks,
 		};
-
+		if (await hasLicense('livechat-enterprise')) {


Here we are creating and using a new license called 'voip-enterprise'

tiagoevanp · 2022-06-21T17:56:51Z

I will approve and merge, but needs more attention when new/voip-outbound->develop

* Clickup Task: https://app.clickup.com/t/22bmce2 Description: Creating EE structure for outbound dialing. Refactored VoIPUser.ts and made necessary fields protected. Created VoIPUser or EEVoipClient based on the licensing in SimpleVoipUser Made necessary changes for using the voip client. * Clickup Task: https://app.clickup.com/t/22bmce2 Description: Adding missing file. * Clickup Task: https://app.clickup.com/t/22bmce2 Description: Connector changes for detecting the outbound call. * Clickup Task: https://app.clickup.com/t/22bmce2 Description: Handling review comments.   ## Proposed changes (including videos or screenshots)    ## Issue(s)  ## Steps to test or reproduce  ## Further comments  Co-authored-by: amolghode1981 <86001342+amolghode1981@users.noreply.github.com> Co-authored-by: Murtaza Patrawala <34130764+murtaza98@users.noreply.github.com> Co-authored-by: Aleksander Nicacio da Silva <6494543+aleksandernsilva@users.noreply.github.com> Co-authored-by: Tiago Evangelista Pinto <17487063+tiagoevanp@users.noreply.github.com> Co-authored-by: Guilherme Gazzo <5263975+ggazzo@users.noreply.github.com>

…ove/message-renderer-tweaks * 'develop' of github.com:RocketChat/Rocket.Chat: [NEW] Enable outbound calling for EE (#25843) (#25960) Chore: Introduce new index to query active livechat conversations for cloud scaling (#26047) [FIX] Importer fails to download files from URLs with query string params (#25934) [IMPROVE] Moved call hold/unhold to EE (#26007) [NEW] Engagement Metrics - Phase 2 (#25505) Chore: Convert usePreventDefault, useQueryOptions, useShortcutOpenMenu (#26035) [FIX] Importer files are unnecessarily transferred over the network. (#25919) Chore: test turbo params (#26038) Chore: Create a token for each action (#26023) Chore: Migrate oembed to ts (#25622) Regression: Fix voip call wrap-up model not working (#26024) Chore: Updating Apps-Engine (#26001) [IMPROVE] Differ Voip calls from Incoming and Outgoing (#25643) [FIX] Append path To Route For Custom Emoji (#24379) [IMPROVE] Moved call wrap up modal to EE (#25875) Chore: Major refactors in pageobjects (#26015)

…/clientPackage * 'develop' of github.com:RocketChat/Rocket.Chat: (80 commits) [NEW] Community Edition Watermark (#25844) [BREAK] remove unused endpoints and restify others (#25889) Chore: add underscore to ddp-streamer [IMPROVE] VoIP admin page cleanup: remove unused settings (#25993) Regression: Fix micro services (#26054) Regression: Fix threads list (#26052) [NEW] VoIP Input/Output Device Selection (#25966) Chore: Account/Profile to TS (#25929) Chore: Add missing Swedish livechat translations (#26048) [IMPROVE] Expand the feature set of the new message rendering (#25970) Chore: Bump fuselage and update icon (#26036) [NEW][APPS] Allowing apps to register authenticated routes (#25937) [NEW] Enable outbound calling for EE (#25843) (#25960) Chore: Introduce new index to query active livechat conversations for cloud scaling (#26047) [FIX] Importer fails to download files from URLs with query string params (#25934) [IMPROVE] Moved call hold/unhold to EE (#26007) [NEW] Engagement Metrics - Phase 2 (#25505) Chore: Convert usePreventDefault, useQueryOptions, useShortcutOpenMenu (#26035) [FIX] Importer files are unnecessarily transferred over the network. (#25919) Chore: test turbo params (#26038) ...

github-actions bot added the stat: needs QA label Jun 13, 2022

amolghode1981 changed the base branch from develop to new/voip-outbound June 13, 2022 13:35

Clickup Task: https://app.clickup.com/t/22bmce2

098c542

Description: Adding missing file.

amolghode1981 marked this pull request as ready for review June 13, 2022 13:41

amolghode1981 requested review from a team as code owners June 13, 2022 13:41

amolghode1981 requested review from tiagoevanp, KevLehman, MartinSchoeler and murtaza98 June 13, 2022 13:42

amolghode1981 added 2 commits June 13, 2022 19:52

Merge remote-tracking branch 'origin/develop' into voip-outbound/outb…

964524a

…oundcall

Clickup Task: https://app.clickup.com/t/22bmce2

7dd6dd1

Description: Connector changes for detecting the outbound call.

KevLehman requested changes Jun 14, 2022

View reviewed changes

murtaza98 reviewed Jun 14, 2022

View reviewed changes

apps/meteor/client/lib/voip/VoIPUser.ts Outdated Show resolved Hide resolved

murtaza98 reviewed Jun 14, 2022

View reviewed changes

apps/meteor/client/lib/voip/VoIPUser.ts Outdated Show resolved Hide resolved

murtaza98 reviewed Jun 14, 2022

View reviewed changes

apps/meteor/ee/client/lib/voip/EEVoipClient.ts Outdated Show resolved Hide resolved

Clickup Task: https://app.clickup.com/t/22bmce2

5ea8a42

Description: Handling review comments.

murtaza98 approved these changes Jun 16, 2022

View reviewed changes

amolghode1981 requested review from KevLehman and murtaza98 June 20, 2022 13:47

Merge remote-tracking branch 'origin/develop' into voip-outbound/outb…

c0ffdcc

…oundcall

tiagoevanp approved these changes Jun 21, 2022

View reviewed changes

tiagoevanp merged commit 877f0b1 into new/voip-outbound Jun 21, 2022

tiagoevanp deleted the voip-outbound/outboundcall branch June 21, 2022 17:57

murtaza98 mentioned this pull request Jul 21, 2022

Release 5.0.0 #26333

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NEW] Enable outbound calling for EE #25843

[NEW] Enable outbound calling for EE #25843

amolghode1981 commented Jun 13, 2022 •

edited

Loading

KevLehman Jun 13, 2022

amolghode1981 Jun 15, 2022

KevLehman Jun 14, 2022

amolghode1981 Jun 15, 2022

KevLehman Jun 14, 2022

amolghode1981 Jun 15, 2022

KevLehman Jun 14, 2022

amolghode1981 Jun 15, 2022 •

edited

Loading

KevLehman Jun 14, 2022

amolghode1981 Jun 15, 2022

murtaza98 left a comment

tiagoevanp Jun 21, 2022

tiagoevanp commented Jun 21, 2022

	if (callDetails.userState === UserState.UAC) {
	if (callDetails.userState !== UserState.UAC) { return }

[NEW] Enable outbound calling for EE #25843

[NEW] Enable outbound calling for EE #25843

Conversation

amolghode1981 commented Jun 13, 2022 • edited Loading

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amolghode1981 Jun 15, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

murtaza98 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tiagoevanp commented Jun 21, 2022

amolghode1981 commented Jun 13, 2022 •

edited

Loading

amolghode1981 Jun 15, 2022 •

edited

Loading