[NEW] Matrix Federation UX improvements #25847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: refactor slash commands (WIP) * chore: prepare federation for EE * fix: fix and move tests * chore: add more test cases
MarcosSpessatto
changed the title
* fix: bridge port * feat: leave matrix room when user leaves rocket room * refactor: leave room method * refactor: setup callbacks * fix: add after leave room callback * fix: fix lint and revert hardcoded port * fix: remove dead code * chore: fix lint Co-authored-by: Marcos Defendi <marcos.defendi@rocket.chat>
* feat: hide msg actions when the room is federated * chore: remove log * fix: remove extra object * WIP review * WIP - Disabled actions example * fix: update based on code review from the FE team * fix: adjust according to the latest develop changes * [NEW] Hide channel actions + message box when the room is federated (#25822) * feat: hide and disable some channels action when federated * feat: hide message box actions + upload when room is federated Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz>
* feat: invite users on channel creation server (WIP) * feat: backend of federation channels * chore: add more test cases * fix: lgtm warning * fix: remove listeners when license is invalid * feat: add validation when add users * fix: fix tests * fix: fix on add users (WIP) * fix: more tweaks (WIP) * fix: wrong condition * fix: fix invites * fix: trying stuff until it works * fix: resolve promise * fix: more tweaks * fix: fixes to support latest develop changes * [NEW] Add federated users on channel creation (#25986) * convert useHasLicense to TS * Make federation setting public * Allow creation of federated channels * Create new autocomplete * Fix state * Fix broken types * Icons * Change Federated hint * fix: fix errors due to the models migration * fix: fix lint Co-authored-by: Marcos Defendi <marcos.defendi@rocket.chat> * fix: invite local users as well * fix: try to fix DMs * fix: trying again (WIP) * fix: removing logs and fixing lint * fix: useless condition * fix: fix broken tests * fix: fix lint Co-authored-by: gabriellsh <40830821+gabriellsh@users.noreply.github.com>
tassoevan
requested changes
Jul 1, 2022
apps/meteor/client/components/UserAutoCompleteMultiple/UserAutoCompleteMultipleOptions.tsx
Show resolved
Hide resolved
tassoevan
previously approved these changes
Jul 1, 2022
There was a problem hiding this comment.
LGTM. I've had requested @gabriellsh to add some comments in code posteriorly.
ggazzo
reviewed
Jul 1, 2022
|
all the actions disabled by federation rooms, are we not missing some tooltip explaining why the functionality is disabled? |
I have added the tooltips for every action that was disabled. :) Thanks. |
kodiakhq
bot
removed
the
stat: ready to merge
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
sampaiodiego
requested changes
Jul 1, 2022
apps/meteor/app/federation-v2/server/infrastructure/matrix/Bridge.ts
Outdated
Show resolved
Hide resolved
apps/meteor/app/federation-v2/server/infrastructure/rocket-chat/adapters/Room.ts
Show resolved
Hide resolved
apps/meteor/app/federation-v2/server/infrastructure/rocket-chat/adapters/Room.ts
Outdated
Show resolved
Hide resolved
apps/meteor/ee/app/federation-v2/server/infrastructure/rocket-chat/adapters/Room.ts
Outdated
Show resolved
Hide resolved
sampaiodiego
previously approved these changes
Jul 1, 2022
…t into feat/federation-ux
ggazzo
approved these changes
Jul 2, 2022
gabriellsh
added a commit
that referenced
this pull request
Jul 4, 2022
* 'develop' of github.com:RocketChat/Rocket.Chat: (29 commits) Chore: move fork of cas module to the monorepo (#26107) Chore: Add Agenda fork to the monorepo (#25681) Chore: Bump deps (#25624) [NEW][ENTERPRISE] Device Management (#25791) Chore: `refactor/tsc-perf` (#26040) [BREAK] Upgrade to version 5.0 can be done only from version 4.x (#26100) [BREAK] Remove support to old MongoDB versions (#26098) [NEW] Matrix Federation UX improvements (#25847) Regression: en.i18n.json spaces [NEW][ENTERPRISE] Introducing dial pad component into sidebar, calls table, contextual bar (#26081) Chore: Settings UI issue (#26053) Chore: Adding default message parser template (#26064) Regression: [VideoConference] If the caller loses connection, direct calls are never canceled (#26099) Chore: Handle errors on index creation (#26094) Chore: fix watermark condition (#26095) [FIX] Validate room access (#24534) [BREAK] VideoConference (#25570) [FIX] Undefined headers on API Client (#26083) Regression: Add Error boundary to katex render component (#26067) Chore: Allow endpoints to optionally require authentication (#26084) ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the following improvements:
/bridgeto/federation(only able to create DMs at this moment)