[NEW][ENTERPRISE] Device Management #25791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Store login on session collection * New Sessions indexes * Create indexes * Skip loginToken Object if undefined * Ternary condition to check loginToken value * destructuring user._id assignment * Some types and interfaces have been updated * Fix lint on IMethodThisType.ts * Connection type as ISocketConnection * Revert changes * Reuse code; fix login token record key case * Add TODO comments * Stop prettier from screaming * Fix formatting Co-authored-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
…Chat into new/device-management
* Session Indexes * store login token on session collection * Session list by user * User Text index * Change to default pattern for session list by user * Check params fo session list by user * Find user by search operator * List all sessions * Temporary fix to add session indexes * Fix imports * Fix if condition * Fix: imports, types and lint * Fix IMDMSession place * Fix IMDMSession import * Merge branch 'develop' into new/session-endpoints * Chore: type pattern * Fix quotes * Chore: PaginatedResult instead of IMDMSession * New: sessions routers * Users model to unset on login token * Route for end-user to logout a specific session * Return 404 for session not found * Update last session when logout * Logout with meteor * Session logout by admin * Fix lint * 2FA to logout as admin * When logout update many with logoutAt * Add session logoutAt with logout Clean up Method * MDM endpoints to EE * Fix: mongo query operator * MDM added as EE bundles * find one by sessionId and userId * Check if is a valid user and if has an EE license * add type string to search params * MDM logout by admin * Back to old logoutCleanUp params * Logout by socket with update many by token * Merge branch 'new/device-management' into new/session-endpoints * Chore: Sessions indexes * Chore: Convert pagination to $facet operator * Chore: remove try/catch * Chore: Verify by permission instead of roles * Set type with function IIRC * Remove method from User and get info by find * Remove duplicate field * Remove extra empty line * Update sessions.ts * Add object logoutBy * Fix indexes and add background run for text index * Session type * remove try/catch * Move permission check to API params * Move updates to models * Prepare indexes for sort operator * Type picking only projected objects * add session index migration * run migration * Session details * Endpoints sessions/info * Add more fields on user text index * User projection and sorte by text score * Fix Typecheck * Validate custom sort operator * Update index.ts * Fix some types * Merge branch 'new/session-endpoints' of https://github.com/RocketChat/Rocket.Chat into new/session-endpoints * Fix: return from getDateObj * Fix CustomSortOp duplicated props * Type for Facet with count * Remove textScore from user projection. * Promise all logout models * Check params with ajv * param sessionId is required * Update sessions.ts * Add import as type * Validate request params with Ajv Co-authored-by: yash-rajpal <rajpal.yash03@gmail.com> Co-authored-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
commit 19a996a Author: Douglas Fabris <devfabris@gmail.com> Date: Thu Jun 2 11:58:46 2022 -0300 [FIX] Unnecessary padding on teams channels footer (#25712) commit 8274ba3 Author: Hugo Costa <hugocarreiracosta@gmail.com> Date: Thu Jun 2 11:00:52 2022 -0300 [FIX] Messages spacing (#25631) * fix(fuselage): adding sequential param to Message Component * chore: updating fuselage version * fix: updating yarn.lock * fix yarn.lock * Update fuselage * remove dev deps Co-authored-by: gabriellsh <gabriel.henriques@rocket.chat> commit d24789a Author: Guilherme Gazzo <guilhermegazzo@gmail.com> Date: Wed Jun 1 17:09:34 2022 -0300 Chore: Custom Sounds Endpoints (#25633) commit db257d3 Author: Murtaza Patrawala <34130764+murtaza98@users.noreply.github.com> Date: Wed Jun 1 22:11:12 2022 +0530 [FIX] User's with non-agent role shown on voip agent association model (#25682) commit c8fba6f Author: Guilherme Gazzo <guilhermegazzo@gmail.com> Date: Wed Jun 1 13:37:58 2022 -0300 Fix CI commit afbb708 Author: Guilherme Gazzo <guilhermegazzo@gmail.com> Date: Wed Jun 1 13:09:17 2022 -0300 fix CI commit c5def57 Author: Júlia Jaeger Foresti <60678893+juliajforesti@users.noreply.github.com> Date: Wed Jun 1 12:27:08 2022 -0300 Chore: Convert CreateChannelWithData (#25667) commit bcd4b1b Author: Júlia Jaeger Foresti <60678893+juliajforesti@users.noreply.github.com> Date: Wed Jun 1 12:25:58 2022 -0300 Chore: Convert UserAutoCompleteMultiple (#25587) Co-authored-by: julia foresti <juliaforesti@julias-MacBook-Pro.local> commit 08656e3 Author: amolghode1981 <86001342+amolghode1981@users.noreply.github.com> Date: Wed Jun 1 20:55:32 2022 +0530 Chore: Converting files from app/livechat folder from JS to TS (#25658) commit c2c1bf4 Author: Jean Brito <jeanfbrito@gmail.com> Date: Wed Jun 1 11:36:08 2022 -0300 Chore: Convert sidebar/header/actions (#25581) Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com> commit 44d6798 Author: Aleksander Nicacio da Silva <aleksander.silva@rocket.chat> Date: Tue May 31 23:00:14 2022 -0300 Chore: Converting omnichannel installation files to ts (#25665) commit cd32f09 Author: Jean Brito <jeanfbrito@gmail.com> Date: Tue May 31 22:55:02 2022 -0300 Chore: Convert to TS omnichannel/agent (#25511) Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com> commit 6b41aa6 Author: Jean Brito <jeanfbrito@gmail.com> Date: Tue May 31 22:52:51 2022 -0300 Chore: Convert components/sidebar to TS (#25429) Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com> commit 6c1a7b1 Author: Júlia Jaeger Foresti <60678893+juliajforesti@users.noreply.github.com> Date: Tue May 31 22:52:04 2022 -0300 Chore: Convert apps/meteor/client/sidebar/header/index (#25671) commit 5b81dba Author: Tasso Evangelista <tasso.evangelista@rocket.chat> Date: Tue May 31 22:51:27 2022 -0300 Chore: Migrate some small helper functions to TypeScript (#25666) commit ad67cd3 Author: Douglas Gubert <douglas.gubert@gmail.com> Date: Tue May 31 22:50:13 2022 -0300 Merge master into develop & Set version to 5.0.0 (#25702) commit 80fc5b7 Author: Douglas Gubert <douglas.gubert@gmail.com> Date: Tue May 31 17:05:29 2022 -0300 Chore: Update Apps-Engine and Fuselage (#25700) commit 88a8e8e Author: Douglas Gubert <douglas.gubert@gmail.com> Date: Tue May 31 11:06:52 2022 -0300 Regression: App event listeners broke Slackbridge integration and importers (#25689) commit bf3483d Author: Guilherme Gazzo <guilhermegazzo@gmail.com> Date: Mon May 30 23:44:01 2022 -0300 [FIX] Fix max-width message block (#25686) commit b1d855e Author: Sinyoung "Divinespear" Kang <divinespear@gmail.com> Date: Tue May 31 10:27:14 2022 +0900 [FIX] Change form body parameter charset to UTF-8 to fix issue #25456 (#25673) commit 51845b1 Author: Guilherme Gazzo <guilhermegazzo@gmail.com> Date: Mon May 30 22:26:55 2022 -0300 Regression: Fix sort field files.list (#25687) Co-authored-by: Fábio Albuquerque <albuquerquefabio@icloud.com> commit 713120e Author: Carlos Rodrigues <carlos.1994hrs@gmail.com> Date: Mon May 30 17:59:57 2022 -0300 fix git conflict (#25684) commit 62405c6 Author: Marcos Spessatto Defendi <marcos.defendi@rocket.chat> Date: Mon May 30 12:47:44 2022 -0300 [FIX] Prevent federation crash on invite users as a non-owner user (#25683) * fix: prevent crashing when inviting someone as non-owner * chore: fix lint commit d364be4 Author: Tasso Evangelista <tasso.evangelista@rocket.chat> Date: Mon May 30 11:21:16 2022 -0300 Regression: Broken components on Federation and Engagement dashboards (#25653) * Fix odd typechecking issues with JSON modules * Avoid `data` as directory for modules * rename other `data` folder Co-authored-by: gabriellsh <gabriel.henriques@rocket.chat> commit 4894fc2 Author: Douglas Fabris <devfabris@gmail.com> Date: Fri May 27 16:23:07 2022 -0300 Regression: Update settings groups description (#25663) commit 5a0d29f Author: Hugo Costa <hugocarreiracosta@gmail.com> Date: Fri May 27 13:45:51 2022 -0300 [FIX] Click to join button Jitsi Call (#25569) * fix: Click to join button Jitsi Call * Fix `yarn` references * fix: Old message Jitsi Button * Fix yarn references (again) * Update apps/meteor/app/action-links/client/lib/actionLinks.ts Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat> * fix: changing instance type Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat> commit 78e57f5 Author: Fábio Albuquerque <albuquerquefabio@icloud.com> Date: Fri May 27 12:54:04 2022 -0300 Regression: Endpoint types with Ajv Coercing data types (#25644) commit 7dd89fc Author: Kevin Aleman <kaleman960@gmail.com> Date: Fri May 27 02:20:57 2022 -0600 Regression: Change logic to check if connection is online on unstable networks (#25618) * Change .race for .allsettled so rejections are handled better * improve to unstable check logic * CR suggestions commit 195f90a Author: Douglas Fabris <devfabris@gmail.com> Date: Thu May 26 23:37:56 2022 -0300 Regression: Missing settings group descriptions (#25639) commit 31ae30f Author: Guilherme Gazzo <guilhermegazzo@gmail.com> Date: Thu May 26 19:11:41 2022 -0300 Chore: Rest API query parameters handling (#25648) commit 052858d Author: Aleksander Nicacio da Silva <aleksander.nsilva@gmail.com> Date: Thu May 26 18:36:07 2022 -0300 Regression: VoIp wrap up modal not opening after call disconnect (#25651) commit 3cd0cab Author: Guilherme Jun Grillo <48109548+guijun13@users.noreply.github.com> Date: Thu May 26 15:39:15 2022 -0300 [FIX] Remove 'total' text in admin info page (#25638) * fix: rm intial 'total' from rooms & total groups * fix: change key of 'total messages' title * feat: cr8 'total_rooms'='Total Rooms' in en.i18n replace it from 'rooms' title in rooms group * fix: change pt-BR.i18n to remove initial 'total' commit 6f3133f Author: Rodrigo Nascimento <rodrigoknascimento@gmail.com> Date: Thu May 26 13:28:48 2022 -0300 Chore: Increase performance and security of integrations’ scripts (#25641) commit cbb0844 Author: Hugo Costa <hugocarreiracosta@gmail.com> Date: Thu May 26 12:12:32 2022 -0300 [FIX] Quote message spacing (#25613) * fix: default margins for outer quote * fix: Removing condition to style differently the inner quote * fix: updating yarn.lock commit 2452448 Author: Douglas Fabris <devfabris@gmail.com> Date: Wed May 25 15:10:07 2022 -0300 Regression: Assets & Slack Bridge Setting Page not rendering (#25629) * fix: RoomPickSettingInput * fix: assets page broken commit ca4c020 Author: Henrique Guimarães Ribeiro <henrique.jobs1@gmail.com> Date: Tue May 24 22:39:11 2022 -0300 Regression: Subscription menu not appearing for non installed but subscribed apps (#25627) * fix: 🐛 Fix subscribe menu option not appearing Fixed a problem on which the AppMenu component did not appear for apps that had an active subscription but weren't installed, now the rendering of the component is also based on the isSubscribed flag, and the appearance of the uninstall and enable/disable options are based on the app.installed flag. * fix: 🐛 Fix AppMenu overflow error on Marketplace/AppRow Fixed a visual error on which the AppMenu component would overflow the right side of its container and have part of itself hidden. * fix: 🐛 FIx isSubscribed wrongful typing Fixed an oversight where I've typed isSubscribed as string instead of boolean
* insertOne instead of createOrUpdate
|
This pull request introduces 3 alerts when merging 3ff4caf into 9629831 - view on LGTM.com new alerts:
|
commit 7857ff4 Author: Guilherme Gazzo <guilhermegazzo@gmail.com> Date: Tue Jun 21 13:34:13 2022 -0300 Chore: Improve CI cache (#25907) Co-authored-by: Diego Sampaio <chinello@gmail.com> commit d1c59c3 Author: Henrique Guimarães Ribeiro <henrique.jobs1@gmail.com> Date: Tue Jun 21 12:46:46 2022 -0300 Regression: Re-add view logs button (#25876) commit 8e7135b Author: Tasso Evangelista <tasso.evangelista@rocket.chat> Date: Tue Jun 21 12:41:09 2022 -0300 Chore: `@rocket.chat/favicon` (#25920) commit dfd1d77 Author: Hugo Costa <hugocarreiracosta@gmail.com> Date: Tue Jun 21 12:26:00 2022 -0300 [FIX] VOIP CallContext snapshot infinite loop (#25947) <!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. --> <!-- Your Pull Request name should start with one of the following tags [NEW] For new features [IMPROVE] For an improvement (performance or little improvements) in existing features [FIX] For bug fixes that affect the end-user [BREAK] For pull requests including breaking changes Chore: For small tasks Doc: For documentation --> <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat - Lint and unit tests pass locally with my changes - I have added tests that prove my fix is effective or that my feature works (if applicable) - I have added necessary documentation (if applicable) - Any dependent changes have been merged and published in downstream modules --> <!-- CHANGELOG --> The application was crashing due to an error on the `useCallerInfo()` hook. The error was:   To prevent this issue to happen it was added a cached and out-of-scope snapshot variable to the hook using `useSyncExternalStore` <!-- Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue below. This description will appear in the release notes if we accept the contribution. --> <!-- END CHANGELOG --> <!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 --> 1. Open rocket.chat server 2. Enable Omnichannel 3. Enable Voip 4. Refresh de page <!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... --> commit 63d4e30 Author: Diego Sampaio <chinello@gmail.com> Date: Mon Jun 20 19:08:04 2022 -0300 Use correct Docker image name on publish commit 9d319ef Author: Diego Sampaio <chinello@gmail.com> Date: Mon Jun 20 17:56:02 2022 -0300 Regression: Docker image publish (#25931) commit 668e6d4 Author: souzaramon <souzaramon.dev@gmail.com> Date: Mon Jun 20 16:54:41 2022 -0300 Revert "Chore: Collect e2e coverage (#25743)" (#25936) This reverts commit e43d0d2. commit e43d0d2 Author: souzaramon <ramon.souza@objective.com.br> Date: Mon Jun 20 14:23:48 2022 -0300 Chore: Collect e2e coverage (#25743) - collect e2e coverage - publish to artifacts - publish badges to gh-pages commit 48e960c Author: Murtaza Patrawala <34130764+murtaza98@users.noreply.github.com> Date: Mon Jun 20 22:37:26 2022 +0530 Regression: Unable to edit user details via admin panel (#25923) commit 9a41c4f Author: Douglas Fabris <devfabris@gmail.com> Date: Mon Jun 20 10:38:15 2022 -0300 [FIX] Members selection field on creating team modal (#25871) <!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. --> <!-- Your Pull Request name should start with one of the following tags [NEW] For new features [IMPROVE] For an improvement (performance or little improvements) in existing features [FIX] For bug fixes that affect the end-user [BREAK] For pull requests including breaking changes Chore: For small tasks Doc: For documentation --> <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat - Lint and unit tests pass locally with my changes - I have added tests that prove my fix is effective or that my feature works (if applicable) - I have added necessary documentation (if applicable) - Any dependent changes have been merged and published in downstream modules --> <!-- CHANGELOG --> <!-- Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue below. This description will appear in the release notes if we accept the contribution. --> - Fix: add members breaking when searching users  <!-- END CHANGELOG --> <!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 --> <!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable --> <!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... --> Co-authored-by: Pierre Lehnen <55164754+pierre-lehnen-rc@users.noreply.github.com> commit acb74f1 Author: Martin Schoeler <martin.schoeler@rocket.chat> Date: Mon Jun 20 10:17:49 2022 -0300 Chore: Remove Imperative Modal from context (#25911) <!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. --> <!-- Your Pull Request name should start with one of the following tags [NEW] For new features [IMPROVE] For an improvement (performance or little improvements) in existing features [FIX] For bug fixes that affect the end-user [BREAK] For pull requests including breaking changes Chore: For small tasks Doc: For documentation --> <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat - Lint and unit tests pass locally with my changes - I have added tests that prove my fix is effective or that my feature works (if applicable) - I have added necessary documentation (if applicable) - Any dependent changes have been merged and published in downstream modules --> This PR revises the usage of the modal inside the call provider, by moving the modal provider a little bit up the three. commit d0078fe Author: Pierre Lehnen <55164754+pierre-lehnen-rc@users.noreply.github.com> Date: Mon Jun 20 09:56:56 2022 -0300 Chore: Keep the option to run only the meteor app (#25915) <!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. --> <!-- Your Pull Request name should start with one of the following tags [NEW] For new features [IMPROVE] For an improvement (performance or little improvements) in existing features [FIX] For bug fixes that affect the end-user [BREAK] For pull requests including breaking changes Chore: For small tasks Doc: For documentation --> <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat - Lint and unit tests pass locally with my changes - I have added tests that prove my fix is effective or that my feature works (if applicable) - I have added necessary documentation (if applicable) - Any dependent changes have been merged and published in downstream modules --> <!-- CHANGELOG --> <!-- Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue below. This description will appear in the release notes if we accept the contribution. --> <!-- END CHANGELOG --> <!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 --> <!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable --> <!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... --> commit d6f4d1b Author: Kevin Aleman <kaleman960@gmail.com> Date: Mon Jun 20 04:57:06 2022 -0600 [FIX] Update chartjs usage to v3 (#25873) <!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. --> <!-- Your Pull Request name should start with one of the following tags [NEW] For new features [IMPROVE] For an improvement (performance or little improvements) in existing features [FIX] For bug fixes that affect the end-user [BREAK] For pull requests including breaking changes Chore: For small tasks Doc: For documentation --> <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat - Lint and unit tests pass locally with my changes - I have added tests that prove my fix is effective or that my feature works (if applicable) - I have added necessary documentation (if applicable) - Any dependent changes have been merged and published in downstream modules --> <!-- CHANGELOG --> <!-- Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue below. This description will appear in the release notes if we accept the contribution. --> <!-- END CHANGELOG --> <!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 --> <!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable --> <!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... --> commit 8637ba2 Author: csuadev <72958726+csuadev@users.noreply.github.com> Date: Mon Jun 20 02:33:55 2022 -0500 Chore: Rewrite AddUsers to TS (#25830) <!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. --> <!-- Your Pull Request name should start with one of the following tags [NEW] For new features [IMPROVE] For an improvement (performance or little improvements) in existing features [FIX] For bug fixes that affect the end-user [BREAK] For pull requests including breaking changes Chore: For small tasks Doc: For documentation --> <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat - Lint and unit tests pass locally with my changes - I have added tests that prove my fix is effective or that my feature works (if applicable) - I have added necessary documentation (if applicable) - Any dependent changes have been merged and published in downstream modules --> <!-- CHANGELOG --> <!-- Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue below. This description will appear in the release notes if we accept the contribution. --> <!-- END CHANGELOG --> <!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 --> <!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable --> <!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... --> Co-authored-by: Douglas Fabris <27704687+dougfabris@users.noreply.github.com> Co-authored-by: Yash Rajpal <58601732+yash-rajpal@users.noreply.github.com> commit 0862751 Author: Tasso Evangelista <tasso.evangelista@rocket.chat> Date: Fri Jun 17 22:09:23 2022 -0300 Chore: Replace `useSubscription` with `useSyncExternalStore` (#25909) <!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. --> <!-- Your Pull Request name should start with one of the following tags [NEW] For new features [IMPROVE] For an improvement (performance or little improvements) in existing features [FIX] For bug fixes that affect the end-user [BREAK] For pull requests including breaking changes Chore: For small tasks Doc: For documentation --> <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat - Lint and unit tests pass locally with my changes - I have added tests that prove my fix is effective or that my feature works (if applicable) - I have added necessary documentation (if applicable) - Any dependent changes have been merged and published in downstream modules --> <!-- CHANGELOG --> <!-- Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue below. This description will appear in the release notes if we accept the contribution. --> <!-- END CHANGELOG --> <!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 --> <!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable --> <!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... --> commit eedc18b Author: Diego Sampaio <chinello@gmail.com> Date: Fri Jun 17 18:00:04 2022 -0300 Chore: Run tests on docker (#25556) Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com> commit 391bb8c Author: Júlia Jaeger Foresti <60678893+juliajforesti@users.noreply.github.com> Date: Fri Jun 17 17:32:56 2022 -0300 Chore: Convert RoomMenu (#25914) <!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. --> <!-- Your Pull Request name should start with one of the following tags [NEW] For new features [IMPROVE] For an improvement (performance or little improvements) in existing features [FIX] For bug fixes that affect the end-user [BREAK] For pull requests including breaking changes Chore: For small tasks Doc: For documentation --> <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat - Lint and unit tests pass locally with my changes - I have added tests that prove my fix is effective or that my feature works (if applicable) - I have added necessary documentation (if applicable) - Any dependent changes have been merged and published in downstream modules --> <!-- CHANGELOG --> <!-- Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue below. This description will appear in the release notes if we accept the contribution. --> <!-- END CHANGELOG --> <!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 --> <!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable --> <!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... --> commit 610670c Author: Pierre Lehnen <55164754+pierre-lehnen-rc@users.noreply.github.com> Date: Fri Jun 17 16:17:18 2022 -0300 [NEW] Create Team with a member list of usernames (#25868) <!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. --> <!-- Your Pull Request name should start with one of the following tags [NEW] For new features [IMPROVE] For an improvement (performance or little improvements) in existing features [FIX] For bug fixes that affect the end-user [BREAK] For pull requests including breaking changes Chore: For small tasks Doc: For documentation --> <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat - Lint and unit tests pass locally with my changes - I have added tests that prove my fix is effective or that my feature works (if applicable) - I have added necessary documentation (if applicable) - Any dependent changes have been merged and published in downstream modules --> <!-- CHANGELOG --> <!-- Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue below. This description will appear in the release notes if we accept the contribution. --> <!-- END CHANGELOG --> <!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 --> <!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable --> <!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... --> Co-authored-by: Douglas Fabris <27704687+dougfabris@users.noreply.github.com> commit 92e3230 Author: Júlia Jaeger Foresti <60678893+juliajforesti@users.noreply.github.com> Date: Fri Jun 17 15:38:21 2022 -0300 Chore: Convert apps/meteor/client/sidebar/search (#25754) <!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. --> <!-- Your Pull Request name should start with one of the following tags [NEW] For new features [IMPROVE] For an improvement (performance or little improvements) in existing features [FIX] For bug fixes that affect the end-user [BREAK] For pull requests including breaking changes Chore: For small tasks Doc: For documentation --> <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat - Lint and unit tests pass locally with my changes - I have added tests that prove my fix is effective or that my feature works (if applicable) - I have added necessary documentation (if applicable) - Any dependent changes have been merged and published in downstream modules --> <!-- CHANGELOG --> <!-- Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue below. This description will appear in the release notes if we accept the contribution. --> <!-- END CHANGELOG --> <!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 --> <!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable --> <!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... --> commit b46cb69 Author: Douglas Fabris <devfabris@gmail.com> Date: Fri Jun 17 15:38:09 2022 -0300 Chore: Split useUserInfoActions into small hooks (#25747) <!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. --> <!-- Your Pull Request name should start with one of the following tags [NEW] For new features [IMPROVE] For an improvement (performance or little improvements) in existing features [FIX] For bug fixes that affect the end-user [BREAK] For pull requests including breaking changes Chore: For small tasks Doc: For documentation --> <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat - Lint and unit tests pass locally with my changes - I have added tests that prove my fix is effective or that my feature works (if applicable) - I have added necessary documentation (if applicable) - Any dependent changes have been merged and published in downstream modules --> <!-- CHANGELOG --> <!-- Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue below. This description will appear in the release notes if we accept the contribution. --> <!-- END CHANGELOG --> <!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 --> <!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable --> <!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... --> commit 06043f5 Author: gabriellsh <40830821+gabriellsh@users.noreply.github.com> Date: Fri Jun 17 13:31:14 2022 -0300 Chore: Watch for package changes (#25910) <!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. --> <!-- Your Pull Request name should start with one of the following tags [NEW] For new features [IMPROVE] For an improvement (performance or little improvements) in existing features [FIX] For bug fixes that affect the end-user [BREAK] For pull requests including breaking changes Chore: For small tasks Doc: For documentation --> <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat - Lint and unit tests pass locally with my changes - I have added tests that prove my fix is effective or that my feature works (if applicable) - I have added necessary documentation (if applicable) - Any dependent changes have been merged and published in downstream modules --> <!-- CHANGELOG --> <!-- Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue below. This description will appear in the release notes if we accept the contribution. --> With the current `dev` pipeline, whenever we modify a package (e.g. `api-client`), we have to kill the meteor proccess and run `yarn dev` again in order for the changes to be compiled and the new output to be used by meteor. This has the drawback of taking a little longer to run the dev environment, since we can't cache a watched buid. In the other hand, it reduces the friction of modifying internal packages since we don't need to rebuild the project for changes to take effect. This will enable us to move more things to separate packages without affecting the dev experience too much. <!-- END CHANGELOG --> <!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 --> <!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable --> <!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... --> commit 42ae7aa Author: Marcos Spessatto Defendi <marcos.defendi@rocket.chat> Date: Fri Jun 17 13:22:44 2022 -0300 Chore: Convert assets endpoint to Typescript (#25358) Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com> Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz> commit 6b6f9dc Author: Guilherme Gazzo <guilhermegazzo@gmail.com> Date: Fri Jun 17 10:37:17 2022 -0300 Chore: Convert users endpoints (#25635) Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz> Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat> commit 2c05ffd Author: Diego Sampaio <chinello@gmail.com> Date: Fri Jun 17 09:59:27 2022 -0300 [FIX] Settings not being overwritten to their default values (#25891) <!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. --> <!-- Your Pull Request name should start with one of the following tags [NEW] For new features [IMPROVE] For an improvement (performance or little improvements) in existing features [FIX] For bug fixes that affect the end-user [BREAK] For pull requests including breaking changes Chore: For small tasks Doc: For documentation --> <!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat - Lint and unit tests pass locally with my changes - I have added tests that prove my fix is effective or that my feature works (if applicable) - I have added necessary documentation (if applicable) - Any dependent changes have been merged and published in downstream modules --> <!-- CHANGELOG --> <!-- Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue below. This description will appear in the release notes if we accept the contribution. --> <!-- END CHANGELOG --> <!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 --> <!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable --> <!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -->
albuquerquefabio
force-pushed
the
new/device-management
branch
from
33aea75
to
4911a08
Compare
* Chore: send param logoutBy when requested by admin * Update Sessions.ts
* WIP: device management admin table * pagination and sorting table * three dot menu * contextual bar and kebab menu * integrate list all API * some more api integration * logout api integrate and lint * admin contextualBar APIs integrate * Error UI * Final changes * lint * oops * some improvements * chore: visual tweaks * fix review * chore: code org * fix permission * hook for logout action * improve checks * remove useless condition * chore: tweaks Co-authored-by: dougfabris <devfabris@gmail.com>
sampaiodiego
requested changes
Jul 1, 2022
sampaiodiego
previously approved these changes
Jul 1, 2022
KevLehman
previously approved these changes
Jul 1, 2022
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
kodiakhq
bot
removed
the
stat: ready to merge
pierre-lehnen-rc
dismissed stale reviews from KevLehman and sampaiodiego
via
0b02b47
ggazzo
previously approved these changes
Jul 2, 2022
sampaiodiego
force-pushed
the
new/device-management
branch
from
4923e01
to
cedede3
Compare
sampaiodiego
approved these changes
Jul 2, 2022
gabriellsh
added a commit
that referenced
this pull request
Jul 4, 2022
* 'develop' of github.com:RocketChat/Rocket.Chat: (29 commits) Chore: move fork of cas module to the monorepo (#26107) Chore: Add Agenda fork to the monorepo (#25681) Chore: Bump deps (#25624) [NEW][ENTERPRISE] Device Management (#25791) Chore: `refactor/tsc-perf` (#26040) [BREAK] Upgrade to version 5.0 can be done only from version 4.x (#26100) [BREAK] Remove support to old MongoDB versions (#26098) [NEW] Matrix Federation UX improvements (#25847) Regression: en.i18n.json spaces [NEW][ENTERPRISE] Introducing dial pad component into sidebar, calls table, contextual bar (#26081) Chore: Settings UI issue (#26053) Chore: Adding default message parser template (#26064) Regression: [VideoConference] If the caller loses connection, direct calls are never canceled (#26099) Chore: Handle errors on index creation (#26094) Chore: fix watermark condition (#26095) [FIX] Validate room access (#24534) [BREAK] VideoConference (#25570) [FIX] Undefined headers on API Client (#26083) Regression: Add Error boundary to katex render component (#26067) Chore: Allow endpoints to optionally require authentication (#26084) ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments