Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVE] VoIP admin page cleanup: remove unused settings #25993

Merged
merged 11 commits into from
Jun 29, 2022
Merged

[IMPROVE] VoIP admin page cleanup: remove unused settings #25993

merged 11 commits into from
Jun 29, 2022

Conversation

cauefcr
Copy link
Contributor

@cauefcr cauefcr commented Jun 23, 2022

Proposed changes (including videos or screenshots)

https://app.clickup.com/t/2n4m61m

Issue(s)

Steps to test or reproduce

Further comments

@cauefcr cauefcr requested review from a team as code owners June 23, 2022 21:48
@cauefcr cauefcr requested review from KevLehman and a team June 23, 2022 21:48
murtaza98 added a commit that referenced this pull request Jun 24, 2022
@murtaza98
suggestions for PR #25993
579639b
murtaza98
murtaza98 suggested changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@murtaza98 murtaza98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cauefcr Overall looks good to me. I just had a couple of suggestions regarding the new DB model package and a missing type check. Added those in this PR: #25998

@cauefcr cauefcr requested a review from murtaza98 June 27, 2022 19:07
KevLehman
KevLehman previously approved these changes Jun 27, 2022
View reviewed changes
@KevLehman KevLehman added this to the 5.0.0 milestone Jun 27, 2022
ggazzo
ggazzo previously approved these changes Jun 28, 2022
View reviewed changes
packages/core-typings/src/IVoipExtension.ts Outdated Show resolved Hide resolved
murtaza98
murtaza98 previously approved these changes Jun 28, 2022
View reviewed changes
@cauefcr cauefcr dismissed stale reviews from murtaza98, ggazzo, and KevLehman via 95e66d2 June 28, 2022 13:00
KevLehman
KevLehman previously approved these changes Jun 28, 2022
View reviewed changes
@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jun 28, 2022
KevLehman
KevLehman previously approved these changes Jun 28, 2022
View reviewed changes
@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Jun 28, 2022
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Jun 28, 2022

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@KevLehman KevLehman dismissed stale reviews from aleksandernsilva and themself via cb58335 June 28, 2022 17:08
@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Jun 28, 2022
KevLehman
KevLehman previously approved these changes Jun 28, 2022
View reviewed changes
@kodiakhq kodiakhq bot merged commit 3a95192 into develop Jun 29, 2022
@kodiakhq kodiakhq bot deleted the improve/voip-admin-cleanup branch June 29, 2022 02:41
@murtaza98 murtaza98 mentioned this pull request Jun 29, 2022
Merged
gabriellsh added a commit that referenced this pull request Jun 29, 2022
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into fix/…
e3d86d5 
…turbo

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [NEW] Community Edition Watermark (#25844)
  [BREAK] remove unused endpoints and restify others (#25889)
  Chore: add underscore to ddp-streamer
  [IMPROVE] VoIP admin page cleanup: remove unused settings (#25993)
  Regression: Fix micro services (#26054)
  Regression: Fix threads list (#26052)
  [NEW] VoIP Input/Output Device Selection (#25966)
  Chore: Account/Profile to TS (#25929)
gabriellsh added a commit that referenced this pull request Jun 29, 2022
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into move…
86260eb 
…/clientPackage

* 'develop' of github.com:RocketChat/Rocket.Chat: (80 commits)
  [NEW] Community Edition Watermark (#25844)
  [BREAK] remove unused endpoints and restify others (#25889)
  Chore: add underscore to ddp-streamer
  [IMPROVE] VoIP admin page cleanup: remove unused settings (#25993)
  Regression: Fix micro services (#26054)
  Regression: Fix threads list (#26052)
  [NEW] VoIP Input/Output Device Selection (#25966)
  Chore: Account/Profile to TS (#25929)
  Chore: Add missing Swedish livechat translations (#26048)
  [IMPROVE] Expand the feature set of the new message rendering (#25970)
  Chore: Bump fuselage and update icon (#26036)
  [NEW][APPS] Allowing apps to register authenticated routes (#25937)
  [NEW] Enable outbound calling for EE (#25843) (#25960)
  Chore: Introduce new index to query active livechat conversations for cloud scaling (#26047)
  [FIX] Importer fails to download files from URLs with query string params (#25934)
  [IMPROVE] Moved call hold/unhold to EE (#26007)
  [NEW] Engagement Metrics - Phase 2 (#25505)
  Chore: Convert usePreventDefault, useQueryOptions, useShortcutOpenMenu (#26035)
  [FIX] Importer files are unnecessarily transferred over the network. (#25919)
  Chore: test turbo params (#26038)
  ...
kodiakhq bot pushed a commit that referenced this pull request Jun 29, 2022
@murtaza98
Regression: Invalid Voip host issue preventing agents connecting to a…
d3e5980 
…sterisk (#26056)

<!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. -->

<!-- Your Pull Request name should start with one of the following tags
  [NEW] For new features
  [IMPROVE] For an improvement (performance or little improvements) in existing features
  [FIX] For bug fixes that affect the end-user
  [BREAK] For pull requests including breaking changes
  Chore: For small tasks
  Doc: For documentation
-->

<!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. 
  - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
  - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
  - Lint and unit tests pass locally with my changes
  - I have added tests that prove my fix is effective or that my feature works (if applicable)
  - I have added necessary documentation (if applicable)
  - Any dependent changes have been merged and published in downstream modules
-->

## Proposed changes (including videos or screenshots)
<!-- CHANGELOG -->
<!--
  Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
  If it fixes a bug or resolves a feature request, be sure to link to that issue below.
  This description will appear in the release notes if we accept the contribution.
-->

<!-- END CHANGELOG -->

## Issue(s)
<!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 -->
One of the settings removed here #25993 was still getting used for getting the asterisk server URL causing this issue
## Steps to test or reproduce
<!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable -->

## Further comments
<!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -->
@murtaza98 murtaza98 mentioned this pull request Jul 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

@KevLehman KevLehman KevLehman approved these changes

@aleksandernsilva aleksandernsilva aleksandernsilva left review comments

@murtaza98 murtaza98 murtaza98 left review comments

Assignees
No one assigned
Labels
stat: QA tested stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cauefcr @ggazzo @aleksandernsilva @KevLehman @murtaza98