[NEW][APPS] Allowing apps to register authenticated routes #25937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| router.use(apiLimiter); | ||
| }); | ||
|
|
||
| router.use((req, res, next) => { | ||
| const { 'x-user-id': userId, 'x-auth-token': authToken, 'x-visitor-token': visitorToken } = req.headers; | ||
| router.use(authenticationMiddleware({ rejectUnauthorized: false })); |
Check failure
Code scanning / CodeQL
Missing rate limiting
|
This pull request introduces 1 alert and fixes 1 when merging c6e8b3f into 63d4e30 - view on LGTM.com new alerts:
fixed alerts:
|
tapiarafael
previously approved these changes
Jun 21, 2022
|
This pull request introduces 1 alert and fixes 1 when merging 421cf6e into 70f5fbe - view on LGTM.com new alerts:
fixed alerts:
|
tapiarafael
previously approved these changes
Jun 23, 2022
tapiarafael
previously approved these changes
Jun 24, 2022
github-actions
bot
added
stat: ready to merge
|
This pull request introduces 1 alert and fixes 1 when merging 0457a4d into d9ffbd6 - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request introduces 1 alert and fixes 1 when merging b638c0c into 89546dd - view on LGTM.com new alerts:
fixed alerts:
|
kodiakhq
bot
removed
the
stat: ready to merge
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
|
This pull request introduces 1 alert and fixes 1 when merging 150a684 into 957c69d - view on LGTM.com new alerts:
fixed alerts:
|
tapiarafael
approved these changes
Jun 28, 2022
gabriellsh
added a commit
that referenced
this pull request
Jun 29, 2022
…/clientPackage * 'develop' of github.com:RocketChat/Rocket.Chat: (80 commits) [NEW] Community Edition Watermark (#25844) [BREAK] remove unused endpoints and restify others (#25889) Chore: add underscore to ddp-streamer [IMPROVE] VoIP admin page cleanup: remove unused settings (#25993) Regression: Fix micro services (#26054) Regression: Fix threads list (#26052) [NEW] VoIP Input/Output Device Selection (#25966) Chore: Account/Profile to TS (#25929) Chore: Add missing Swedish livechat translations (#26048) [IMPROVE] Expand the feature set of the new message rendering (#25970) Chore: Bump fuselage and update icon (#26036) [NEW][APPS] Allowing apps to register authenticated routes (#25937) [NEW] Enable outbound calling for EE (#25843) (#25960) Chore: Introduce new index to query active livechat conversations for cloud scaling (#26047) [FIX] Importer fails to download files from URLs with query string params (#25934) [IMPROVE] Moved call hold/unhold to EE (#26007) [NEW] Engagement Metrics - Phase 2 (#25505) Chore: Convert usePreventDefault, useQueryOptions, useShortcutOpenMenu (#26035) [FIX] Importer files are unnecessarily transferred over the network. (#25919) Chore: test turbo params (#26038) ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Adds adaptations that allow apps to declare an API endpoint that requires authorization from Rocket.Chat prior to executing
Issue(s)
Steps to test or reproduce
Further comments
PR on Apps-Engine side RocketChat/Rocket.Chat.Apps-engine#523