chore: Allow admin to access any groups info and groups members. #26423
+382
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albuquerquefabio
changed the title
|
This pull request introduces 2 alerts when merging 33e0adf into b11bab5 - view on LGTM.com new alerts:
|
LucianoPierdona
previously approved these changes
Aug 25, 2022
|
This pull request introduces 2 alerts when merging 939bb95 into e13d7d2 - view on LGTM.com new alerts:
|
|
@albuquerquefabio can you describe better what this change does? |
|
Description updated. |
dionisio-bot
bot
added
the
stat: ready to merge
jessicaschelly
added
stat: needs QA
and removed
stat: ready to merge
albuquerquefabio
changed the title
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR allows the admin to access any group info and members. But, the admin cannot access messages from groups that they not joining.
Issue(s)
Admins don't receive information about private rooms it is not a member of.
#15435
Steps to test or reproduce
Further comments
AD-136