[FIX] Toast notification ignoring 403 errors #27624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rned by generic api
Codecov Report
@@ Coverage Diff @@
## develop #27624 +/- ##
===========================================
+ Coverage 41.94% 42.82% +0.87%
===========================================
Files 845 818 -27
Lines 17799 17282 -517
Branches 2019 1944 -75
===========================================
- Hits 7466 7401 -65
+ Misses 10068 9615 -453
- Partials 265 266 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
KevLehman
previously requested changes
Dec 26, 2022
aleksandernsilva
approved these changes
Jan 19, 2023
dionisio-bot
bot
added
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Jan 30, 2023
…etChat/Rocket.Chat into matrixSearch * 'feat/federation-search-public-rooms' of github.com:RocketChat/Rocket.Chat: fix: prevent to the user join the room twice Chore: OmnichannelRoomIconProvider order breaking VideoConfPopup (#27740) [FIX] Toast notification ignoring 403 errors (#27624) [FIX] Not all messages in chat conversations are available when forwarding between agents or departments. (#27816) [IMPROVE] Emoji picker for large amount of custom emojis (#27745)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
OC-528
Steps to test or reproduce
Further comments