Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Not all messages in chat conversations are available when forwarding between agents or departments. #27816

Merged
merged 2 commits into from Jan 24, 2023

Conversation

filipemarins
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

The room manager wasn't being cleared when the livechat chat was forwarded.

@filipemarins filipemarins marked this pull request as ready for review January 23, 2023 18:24
@filipemarins filipemarins requested a review from a team as a code owner January 23, 2023 18:24
@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Merging #27816 (2ce8bea) into develop (a50dfb4) will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27816      +/-   ##
===========================================
- Coverage    43.02%   42.90%   -0.13%     
===========================================
  Files          818      818              
  Lines        17282    17282              
  Branches      1944     1944              
===========================================
- Hits          7436     7415      -21     
- Misses        9580     9603      +23     
+ Partials       266      264       -2     
Flag Coverage Δ
e2e 42.90% <ø> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jan 24, 2023
@filipemarins filipemarins added this to the 6.0.0 milestone Jan 24, 2023
@kodiakhq kodiakhq bot merged commit 43b667f into develop Jan 24, 2023
@kodiakhq kodiakhq bot deleted the oc-594 branch January 24, 2023 13:03
@filipemarins filipemarins removed this from the 6.0.0 milestone Jan 24, 2023
@ggazzo ggazzo added this to the 5.4.2 milestone Jan 24, 2023
@filipemarins filipemarins modified the milestones: 5.4.2, 5.3.6 Jan 24, 2023
sampaiodiego pushed a commit that referenced this pull request Jan 24, 2023
@sampaiodiego sampaiodiego mentioned this pull request Jan 24, 2023
sampaiodiego pushed a commit that referenced this pull request Jan 24, 2023
@sampaiodiego sampaiodiego mentioned this pull request Jan 24, 2023
gabriellsh added a commit that referenced this pull request Jan 30, 2023
…etChat/Rocket.Chat into matrixSearch

* 'feat/federation-search-public-rooms' of github.com:RocketChat/Rocket.Chat:
  fix: prevent to the user join the room twice
  Chore: OmnichannelRoomIconProvider order breaking VideoConfPopup (#27740)
  [FIX] Toast notification ignoring 403 errors (#27624)
  [FIX] Not all messages in chat conversations are available when forwarding between agents or departments. (#27816)
  [IMPROVE] Emoji picker for large amount of custom emojis (#27745)
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA tested stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants