Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVE] Emoji picker for large amount of custom emojis #27745

Merged
merged 10 commits into from Jan 23, 2023

Conversation

sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Jan 12, 2023

Proposed changes (including videos or screenshots)

There are a few items fixed on this PR:

  • The emoji picker now shows only 90 emojis (10 rows) at first, with a link to load more
  • There was an issue causing the emoji picker to be rendered at startup, causing the UI to freeze for large amounts of custom emojis. It was fixed and now it renders only after clicking the button to show the picker
  • Custom emojis are now loaded respecting the CDN prefix setting, which will allow them to be served a CDN

Issue(s)

ARCH-127

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Merging #27745 (0ab49bf) into develop (16eacbf) will increase coverage by 0.89%.
The diff coverage is 47.22%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27745      +/-   ##
===========================================
+ Coverage    41.97%   42.87%   +0.89%     
===========================================
  Files          845      818      -27     
  Lines        17783    17282     -501     
  Branches      2019     1944      -75     
===========================================
- Hits          7464     7409      -55     
+ Misses       10053     9607     -446     
  Partials       266      266              
Flag Coverage Δ
e2e 42.87% <47.22%> (+0.89%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rodrigok rodrigok added this to the 5.2.2 milestone Jan 19, 2023
@sampaiodiego sampaiodiego changed the title [IMPROVE] Show button to load more custom emojis on emoji picker [IMPROVE] Custom emoji picker for large amounts of emojis Jan 20, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jan 23, 2023
@sampaiodiego sampaiodiego changed the title [IMPROVE] Custom emoji picker for large amounts of emojis [IMPROVE] Emoji picker for large amount of custom emojis Jan 23, 2023
@sampaiodiego sampaiodiego merged commit a50dfb4 into develop Jan 23, 2023
@sampaiodiego sampaiodiego deleted the show-load-more-custom-emoji branch January 23, 2023 19:39
@sampaiodiego sampaiodiego mentioned this pull request Jan 24, 2023
@sampaiodiego sampaiodiego mentioned this pull request Jan 24, 2023
@sampaiodiego sampaiodiego mentioned this pull request Jan 24, 2023
gabriellsh added a commit that referenced this pull request Jan 30, 2023
…etChat/Rocket.Chat into matrixSearch

* 'feat/federation-search-public-rooms' of github.com:RocketChat/Rocket.Chat:
  fix: prevent to the user join the room twice
  Chore: OmnichannelRoomIconProvider order breaking VideoConfPopup (#27740)
  [FIX] Toast notification ignoring 403 errors (#27624)
  [FIX] Not all messages in chat conversations are available when forwarding between agents or departments. (#27816)
  [IMPROVE] Emoji picker for large amount of custom emojis (#27745)
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants