Regression: Fix improper usage of useEndpointData #28050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevLehman
changed the title
MartinSchoeler
previously requested changes
Feb 15, 2023
Codecov Report
@@ Coverage Diff @@
## develop #28050 +/- ##
============================================
- Coverage 44.85% 32.20% -12.65%
============================================
Files 766 628 -138
Lines 14903 12485 -2418
Branches 2070 1849 -221
============================================
- Hits 6684 4021 -2663
- Misses 7925 8263 +338
+ Partials 294 201 -93
Flags with carried forward coverage won't be shown. Click here to find out more. |
ggazzo
previously requested changes
Feb 17, 2023
apps/meteor/client/views/omnichannel/directory/chats/ChatTable.tsx
Outdated
Show resolved
Hide resolved
|
Thanks for the review! Converted useEndpointData to tanstack's query. Pls check :) |
MartinSchoeler
requested changes
Feb 17, 2023
apps/meteor/client/views/omnichannel/directory/chats/ChatTable.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/omnichannel/directory/chats/ChatTable.tsx
Outdated
Show resolved
Hide resolved
MartinSchoeler
previously approved these changes
Feb 17, 2023
KevLehman
commented
Feb 21, 2023
apps/meteor/client/views/omnichannel/directory/OmnichannelDirectoryPage.tsx
Show resolved
Hide resolved
…m:RocketChat/Rocket.Chat into regression/chats-panel-missing-permission
MartinSchoeler
approved these changes
Feb 22, 2023
dionisio-bot
bot
added
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Feb 24, 2023
…jumpToMessage * 'develop' of github.com:RocketChat/Rocket.Chat: Regression: Fix RegisterForm Translations (#28156) Chore: e2e omnichannel tests - Close every opened page after the test (#28152) Chore: Remove fail-fast from matrix strategy (#28153) Chore: Fix houston metadata Regression: Fix improper usage of useEndpointData (#28050) Regression: View mode preferences without the selected option by default (#28120) Chore: Fix fetching Apps-Engine and MongoDB versions for release notes (#28129) Regression: Slash commands detected at any line (#28142) Regression: App requests notify admin function generating wrong link (#28111) Chore: Improve time of meteor build (#28128) Chore: Update tokens (#28079) Regression: Fix sidebar horizontal scrolling (#28125) Chore: Presence cap tweaks (#28058) Chore: Fix Services Docker Build Chore: Custom CSS (#27993) Chore: Fix CI Docker Alpine build missing (#28138) Chore: Fix CI docker publish (#28134) Chore: Refactor CI to improve code reusability and organization (#28108)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
OC-627