Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Improve time of meteor build #28128

Merged
merged 40 commits into from Feb 23, 2023
Merged

Chore: Improve time of meteor build #28128

merged 40 commits into from Feb 23, 2023

Conversation

rodrigok
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@rodrigok rodrigok force-pushed the improve/ci-yarn-cache branch 4 times, most recently from 8a2024e to 1f7cba5 Compare February 22, 2023 23:51
@rodrigok rodrigok force-pushed the improve/ci-yarn-cache branch 3 times, most recently from b6f28b6 to b59c99d Compare February 23, 2023 01:00
@rodrigok rodrigok changed the title Chore: Improve CI cache Chore: Improve cache of node_modules on CI Feb 23, 2023
@ggazzo ggazzo marked this pull request as ready for review February 23, 2023 01:39
@ggazzo ggazzo requested a review from a team as a code owner February 23, 2023 01:39
@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Merging #28128 (c270350) into develop (09b1ef7) will decrease coverage by 11.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop   #28128       +/-   ##
============================================
- Coverage    44.87%   33.86%   -11.01%     
============================================
  Files          766      684       -82     
  Lines        14903    13824     -1079     
  Branches      2070     1997       -73     
============================================
- Hits          6688     4682     -2006     
- Misses        7922     8890      +968     
+ Partials       293      252       -41     
Flag Coverage Δ
e2e 33.86% <ø> (-10.97%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rodrigok rodrigok marked this pull request as draft February 23, 2023 14:40
Base automatically changed from improve/ci-dry-more to develop February 23, 2023 15:07
# Conflicts:
#	.github/actions/setup-node/action.yml
#	.github/workflows/ci-code-check.yml
#	.github/workflows/ci-test-e2e.yml
#	.github/workflows/ci-test-unit.yml
#	.github/workflows/ci.yml
@rodrigok rodrigok changed the title Chore: Improve cache of node_modules on CI Chore: Improve time of meteor build Feb 23, 2023
@rodrigok rodrigok marked this pull request as ready for review February 23, 2023 18:00
@ggazzo ggazzo merged commit f17ded5 into develop Feb 23, 2023
@ggazzo ggazzo deleted the improve/ci-yarn-cache branch February 23, 2023 22:59
gabriellsh added a commit that referenced this pull request Feb 24, 2023
…jumpToMessage

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression: Fix RegisterForm Translations (#28156)
  Chore: e2e omnichannel tests - Close every opened page after the test (#28152)
  Chore: Remove fail-fast from matrix strategy (#28153)
  Chore: Fix houston metadata
  Regression: Fix improper usage of useEndpointData (#28050)
  Regression: View mode preferences without the selected option by default (#28120)
  Chore: Fix fetching Apps-Engine and MongoDB versions for release notes (#28129)
  Regression: Slash commands detected at any line (#28142)
  Regression: App requests notify admin function generating wrong link (#28111)
  Chore: Improve time of meteor build (#28128)
  Chore: Update tokens (#28079)
  Regression: Fix sidebar horizontal scrolling (#28125)
  Chore: Presence cap tweaks (#28058)
  Chore: Fix Services Docker Build
  Chore: Custom CSS  (#27993)
  Chore: Fix CI Docker Alpine build missing (#28138)
  Chore: Fix CI docker publish (#28134)
  Chore: Refactor CI to improve code reusability and organization (#28108)
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants