Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update tokens #28079

Merged
merged 7 commits into from Feb 23, 2023
Merged

Chore: Update tokens #28079

merged 7 commits into from Feb 23, 2023

Conversation

juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Feb 16, 2023

  • Add token surface-overlay
  • Change token font-default on dark palette (solves OC-577 )

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@juliajforesti juliajforesti requested a review from a team February 16, 2023 21:43
@juliajforesti juliajforesti marked this pull request as ready for review February 17, 2023 20:43
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Feb 17, 2023
@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Feb 22, 2023
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Feb 22, 2023

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@juliajforesti juliajforesti changed the title Chore: Add surface-overlay token Chore: Update tokens Feb 23, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: conflict labels Feb 23, 2023
@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Merging #28079 (4875259) into develop (497f2be) will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28079      +/-   ##
===========================================
- Coverage    44.92%   44.85%   -0.08%     
===========================================
  Files          766      766              
  Lines        14903    14903              
  Branches      2070     2070              
===========================================
- Hits          6695     6684      -11     
- Misses        7916     7927      +11     
  Partials       292      292              
Flag Coverage Δ
e2e 44.80% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo merged commit 62b13ff into develop Feb 23, 2023
@ggazzo ggazzo deleted the chore/surface-overlay branch February 23, 2023 21:10
gabriellsh added a commit that referenced this pull request Feb 24, 2023
…jumpToMessage

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression: Fix RegisterForm Translations (#28156)
  Chore: e2e omnichannel tests - Close every opened page after the test (#28152)
  Chore: Remove fail-fast from matrix strategy (#28153)
  Chore: Fix houston metadata
  Regression: Fix improper usage of useEndpointData (#28050)
  Regression: View mode preferences without the selected option by default (#28120)
  Chore: Fix fetching Apps-Engine and MongoDB versions for release notes (#28129)
  Regression: Slash commands detected at any line (#28142)
  Regression: App requests notify admin function generating wrong link (#28111)
  Chore: Improve time of meteor build (#28128)
  Chore: Update tokens (#28079)
  Regression: Fix sidebar horizontal scrolling (#28125)
  Chore: Presence cap tweaks (#28058)
  Chore: Fix Services Docker Build
  Chore: Custom CSS  (#27993)
  Chore: Fix CI Docker Alpine build missing (#28138)
  Chore: Fix CI docker publish (#28134)
  Chore: Refactor CI to improve code reusability and organization (#28108)
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants