Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Fix fetching Apps-Engine and MongoDB versions for release notes #28129

Merged
merged 3 commits into from Feb 24, 2023

Conversation

sampaiodiego
Copy link
Member

Proposed changes (including videos or screenshots)

Latest releases were missing the Apps Engine version information since we moved to monorepo.

The script to fetch this info was still relying on package-lock.json from apps/meteor, but this file doesn't exist anymore, and houston was throwing this error when trying to get the data:

GitError: fatal: path 'apps/meteor/package-lock.json' does not exist in 'HEAD'

    at Object.action (/xxx/.nvm/versions/node/v14.21.2/lib/node_modules/@rocket.chat/houston/node_modules/simple-git/src/lib/plugins/error-detection.plugin.js:30:33)
    at PluginStore.exec (/xxx/.nvm/versions/node/v14.21.2/lib/node_modules/@rocket.chat/houston/node_modules/simple-git/src/lib/plugins/plugin-store.js:21:33)
    at /xxx/.nvm/versions/node/v14.21.2/lib/node_modules/@rocket.chat/houston/node_modules/simple-git/src/lib/runners/git-executor-chain.js:95:45
    at new Promise (<anonymous>)
    at GitExecutorChain.handleTaskData (/xxx/.nvm/versions/node/v14.21.2/lib/node_modules/@rocket.chat/houston/node_modules/simple-git/src/lib/runners/git-executor-chain.js:93:16)
    at GitExecutorChain.<anonymous> (/xxx/.nvm/versions/node/v14.21.2/lib/node_modules/@rocket.chat/houston/node_modules/simple-git/src/lib/runners/git-executor-chain.js:77:46)
    at Generator.next (<anonymous>)
    at fulfilled (/xxx/.nvm/versions/node/v14.21.2/lib/node_modules/@rocket.chat/houston/node_modules/simple-git/src/lib/runners/git-executor-chain.js:5:58) {
  task: {
    commands: [ 'show', 'HEAD:apps/meteor/package-lock.json' ],
    format: 'utf-8',
    parser: [Function: parser]
  }
}

Issue(s)

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Merging #28129 (e666480) into develop (f17ded5) will increase coverage by 5.35%.
The diff coverage is n/a.

❗ Current head e666480 differs from pull request most recent head 6e68b47. Consider uploading reports for the commit 6e68b47 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28129      +/-   ##
===========================================
+ Coverage    39.57%   44.93%   +5.35%     
===========================================
  Files          745      766      +21     
  Lines        14684    14903     +219     
  Branches      2032     2070      +38     
===========================================
+ Hits          5811     6696     +885     
+ Misses        8601     7915     -686     
- Partials       272      292      +20     
Flag Coverage Δ
e2e 44.89% <ø> (+5.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

ggazzo
ggazzo previously approved these changes Feb 23, 2023
d-gubert
d-gubert previously approved these changes Feb 23, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Feb 23, 2023
@ggazzo ggazzo added this pull request to the merge queue Feb 24, 2023
@sampaiodiego sampaiodiego removed this pull request from the merge queue due to a manual request Feb 24, 2023
@sampaiodiego sampaiodiego dismissed stale reviews from d-gubert and ggazzo via 6e68b47 February 24, 2023 00:36
@sampaiodiego sampaiodiego changed the title Chore: Fix fetching apps-engine version for release notes Chore: Fix fetching Apps-Engine and MongoDB versions for release notes Feb 24, 2023
@sampaiodiego sampaiodiego merged commit f035a20 into develop Feb 24, 2023
@sampaiodiego sampaiodiego deleted the fix-app-version-release-notes branch February 24, 2023 00:39
gabriellsh added a commit that referenced this pull request Feb 24, 2023
…jumpToMessage

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression: Fix RegisterForm Translations (#28156)
  Chore: e2e omnichannel tests - Close every opened page after the test (#28152)
  Chore: Remove fail-fast from matrix strategy (#28153)
  Chore: Fix houston metadata
  Regression: Fix improper usage of useEndpointData (#28050)
  Regression: View mode preferences without the selected option by default (#28120)
  Chore: Fix fetching Apps-Engine and MongoDB versions for release notes (#28129)
  Regression: Slash commands detected at any line (#28142)
  Regression: App requests notify admin function generating wrong link (#28111)
  Chore: Improve time of meteor build (#28128)
  Chore: Update tokens (#28079)
  Regression: Fix sidebar horizontal scrolling (#28125)
  Chore: Presence cap tweaks (#28058)
  Chore: Fix Services Docker Build
  Chore: Custom CSS  (#27993)
  Chore: Fix CI Docker Alpine build missing (#28138)
  Chore: Fix CI docker publish (#28134)
  Chore: Refactor CI to improve code reusability and organization (#28108)
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants