New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Fix fetching Apps-Engine and MongoDB versions for release notes #28129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #28129 +/- ##
===========================================
+ Coverage 39.57% 44.93% +5.35%
===========================================
Files 745 766 +21
Lines 14684 14903 +219
Branches 2032 2070 +38
===========================================
+ Hits 5811 6696 +885
+ Misses 8601 7915 -686
- Partials 272 292 +20
Flags with carried forward coverage won't be shown. Click here to find out more. |
ggazzo
previously approved these changes
Feb 23, 2023
d-gubert
previously approved these changes
Feb 23, 2023
dionisio-bot
bot
added
stat: ready to merge
PR tested and approved waiting for merge
and removed
stat: needs QA
labels
Feb 23, 2023
sampaiodiego
changed the title
Chore: Fix fetching apps-engine version for release notes
Chore: Fix fetching Apps-Engine and MongoDB versions for release notes
Feb 24, 2023
gabriellsh
added a commit
that referenced
this pull request
Feb 24, 2023
…jumpToMessage * 'develop' of github.com:RocketChat/Rocket.Chat: Regression: Fix RegisterForm Translations (#28156) Chore: e2e omnichannel tests - Close every opened page after the test (#28152) Chore: Remove fail-fast from matrix strategy (#28153) Chore: Fix houston metadata Regression: Fix improper usage of useEndpointData (#28050) Regression: View mode preferences without the selected option by default (#28120) Chore: Fix fetching Apps-Engine and MongoDB versions for release notes (#28129) Regression: Slash commands detected at any line (#28142) Regression: App requests notify admin function generating wrong link (#28111) Chore: Improve time of meteor build (#28128) Chore: Update tokens (#28079) Regression: Fix sidebar horizontal scrolling (#28125) Chore: Presence cap tweaks (#28058) Chore: Fix Services Docker Build Chore: Custom CSS (#27993) Chore: Fix CI Docker Alpine build missing (#28138) Chore: Fix CI docker publish (#28134) Chore: Refactor CI to improve code reusability and organization (#28108)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Latest releases were missing the Apps Engine version information since we moved to monorepo.
The script to fetch this info was still relying on
package-lock.json
fromapps/meteor
, but this file doesn't exist anymore, andhouston
was throwing this error when trying to get the data:Issue(s)
Steps to test or reproduce
Further comments