Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use local httpbin container on github CI's #29067

Merged
merged 13 commits into from
May 17, 2023
Merged

Conversation

murtaza98
Copy link
Contributor

@murtaza98 murtaza98 commented Apr 27, 2023

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/OC-914

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #29067 (88e941b) into develop (2ce613b) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #29067      +/-   ##
===========================================
- Coverage    46.10%   46.05%   -0.05%     
===========================================
  Files          727      727              
  Lines        14066    14066              
  Branches      2251     2251              
===========================================
- Hits          6485     6478       -7     
- Misses        7263     7270       +7     
  Partials       318      318              
Flag Coverage Δ
e2e 46.02% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@murtaza98 murtaza98 marked this pull request as ready for review April 28, 2023 09:56
@murtaza98 murtaza98 requested a review from a team as a code owner April 28, 2023 09:56
KevLehman
KevLehman previously approved these changes May 9, 2023
@sampaiodiego sampaiodiego changed the title chore: use local httpbin container on github CI's test: use local httpbin container on github CI's May 17, 2023
@sampaiodiego sampaiodiego merged commit ec4394e into develop May 17, 2023
9 of 10 checks passed
@sampaiodiego sampaiodiego deleted the local-httpbin branch May 17, 2023 14:12
gabriellsh added a commit that referenced this pull request May 23, 2023
…memberList

* 'develop' of github.com:RocketChat/Rocket.Chat: (72 commits)
  fix: respect useEmoji pref on messages (#28975)
  chore: Move 2fa challenge handler to rest api package (#29263)
  refactor(integrations): Replace Fibers dependency by Deasync (#29081)
  chore: improve server stream typings (#29128)
  fix: Livechat `CSP` whitelist validation (#29278)
  chore: `ListItem` stories (#29251)
  regression(push): fix error when adding headers to send push notification (#29287)
  fix: Handle login services errors (#28795)
  chore: skip hook if HUSKY env var is set to 0 (#29283)
  ci: skip husky hooks on ci (#29279)
  chore: Add `roomName` on Composer placeholder (#29255)
  regression: fix console warnings (#29277)
  ci: fix Release Task
  chore: Add Changesets (#29275)
  feat(Marketplace): Scroll to the top of the marketplace apps list when page changed (#29095)
  fix: Members/Channels list infinite scroll (#28636)
  test: use local httpbin container on github CI's (#29067)
  Bump vm2 version 3.9.19 (#29258)
  i18n: Language update from LingoHub 🤖 on 2023-05-16Z (#29252)
  chore: Composer missing scrollbar color (#29256)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants