Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect useEmoji pref on messages #28975

Merged
merged 11 commits into from
May 19, 2023
Merged

fix: respect useEmoji pref on messages #28975

merged 11 commits into from
May 19, 2023

Conversation

yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented Apr 19, 2023

Proposed changes (including videos or screenshots)

image

Issue(s)

Steps to test or reproduce

Further comments

SUP-185

@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Merging #28975 (2c3df05) into develop (40cebcc) will decrease coverage by 1.14%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28975      +/-   ##
===========================================
- Coverage    46.75%   45.62%   -1.14%     
===========================================
  Files          707      702       -5     
  Lines        13238    13108     -130     
  Branches      2220     2215       -5     
===========================================
- Hits          6190     5980     -210     
- Misses        6732     6826      +94     
+ Partials       316      302      -14     
Flag Coverage Δ
e2e 45.58% <ø> (-1.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@yash-rajpal yash-rajpal marked this pull request as ready for review May 10, 2023 16:06
@yash-rajpal yash-rajpal requested a review from a team as a code owner May 10, 2023 16:06
@yash-rajpal yash-rajpal changed the title fix: respect useEmoji pref on reactions fix: respect useEmoji pref on messages May 10, 2023
gabriellsh
gabriellsh previously approved these changes May 16, 2023
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 18, 2023
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label May 19, 2023
@changeset-bot
Copy link

changeset-bot bot commented May 19, 2023

🦋 Changeset detected

Latest commit: 2c3df05

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 27 packages
Name Type
@rocket.chat/gazzodown Major
@rocket.chat/meteor Minor
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/api-client Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/models Patch
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 19, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels May 19, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels May 19, 2023
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label May 19, 2023
@yash-rajpal yash-rajpal added the stat: ready to merge PR tested and approved waiting for merge label May 19, 2023
@kodiakhq kodiakhq bot merged commit 9ea8088 into develop May 19, 2023
36 of 37 checks passed
@kodiakhq kodiakhq bot deleted the fix/useEmoji-pref branch May 19, 2023 15:41
gabriellsh added a commit that referenced this pull request May 23, 2023
…memberList

* 'develop' of github.com:RocketChat/Rocket.Chat: (72 commits)
  fix: respect useEmoji pref on messages (#28975)
  chore: Move 2fa challenge handler to rest api package (#29263)
  refactor(integrations): Replace Fibers dependency by Deasync (#29081)
  chore: improve server stream typings (#29128)
  fix: Livechat `CSP` whitelist validation (#29278)
  chore: `ListItem` stories (#29251)
  regression(push): fix error when adding headers to send push notification (#29287)
  fix: Handle login services errors (#28795)
  chore: skip hook if HUSKY env var is set to 0 (#29283)
  ci: skip husky hooks on ci (#29279)
  chore: Add `roomName` on Composer placeholder (#29255)
  regression: fix console warnings (#29277)
  ci: fix Release Task
  chore: Add Changesets (#29275)
  feat(Marketplace): Scroll to the top of the marketplace apps list when page changed (#29095)
  fix: Members/Channels list infinite scroll (#28636)
  test: use local httpbin container on github CI's (#29067)
  Bump vm2 version 3.9.19 (#29258)
  i18n: Language update from LingoHub 🤖 on 2023-05-16Z (#29252)
  chore: Composer missing scrollbar color (#29256)
  ...
@scuciatto scuciatto added this to the 6.3.0 milestone Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA tested stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants