Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: ListItem stories #29251

Merged
merged 6 commits into from
May 18, 2023
Merged

chore: ListItem stories #29251

merged 6 commits into from
May 18, 2023

Conversation

juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented May 16, 2023 •
edited

Proposed changes (including videos or screenshots)

  • create ListItem stories applied on Dropdown

Stories:

  • With Icons
  • No Icons
  • Mixed (with and without icons) - with gap
  • Mixed (with and without icons) - without gap

Issue(s)

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented May 16, 2023 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (develop@eee580d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #29251   +/-   ##
==========================================
  Coverage           ?   40.97%           
==========================================
  Files              ?      688           
  Lines              ?    13015           
  Branches           ?     2178           
==========================================
  Hits               ?     5333           
  Misses             ?     7398           
  Partials           ?      284
Flag Coverage Δ
e2e 40.95% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@juliajforesti juliajforesti marked this pull request as ready for review May 16, 2023 16:39
@juliajforesti juliajforesti requested a review from a team as a code owner May 16, 2023 16:39
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels May 17, 2023
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label May 17, 2023
@changeset-bot
Copy link

changeset-bot bot commented May 17, 2023 •
edited

⚠️ No Changeset found

Latest commit: c9dd8cf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 17, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels May 18, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels May 18, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels May 18, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels May 18, 2023
@kodiakhq kodiakhq bot merged commit 3ad30b4 into develop May 18, 2023
@kodiakhq kodiakhq bot deleted the chore/ListItem-stories branch May 18, 2023 20:27
gabriellsh added a commit that referenced this pull request May 23, 2023
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into fix/…
a3de2dc 
…memberList

* 'develop' of github.com:RocketChat/Rocket.Chat: (72 commits)
  fix: respect useEmoji pref on messages (#28975)
  chore: Move 2fa challenge handler to rest api package (#29263)
  refactor(integrations): Replace Fibers dependency by Deasync (#29081)
  chore: improve server stream typings (#29128)
  fix: Livechat `CSP` whitelist validation (#29278)
  chore: `ListItem` stories (#29251)
  regression(push): fix error when adding headers to send push notification (#29287)
  fix: Handle login services errors (#28795)
  chore: skip hook if HUSKY env var is set to 0 (#29283)
  ci: skip husky hooks on ci (#29279)
  chore: Add `roomName` on Composer placeholder (#29255)
  regression: fix console warnings (#29277)
  ci: fix Release Task
  chore: Add Changesets (#29275)
  feat(Marketplace): Scroll to the top of the marketplace apps list when page changed (#29095)
  fix: Members/Channels list infinite scroll (#28636)
  test: use local httpbin container on github CI's (#29067)
  Bump vm2 version 3.9.19 (#29258)
  i18n: Language update from LingoHub 🤖 on 2023-05-16Z (#29252)
  chore: Composer missing scrollbar color (#29256)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougfabris dougfabris dougfabris approved these changes

Assignees
No one assigned
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@juliajforesti @dougfabris