regression(push): fix error when adding headers to send push notification #29287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report
@@ Coverage Diff @@
## develop #29287 +/- ##
===========================================
- Coverage 46.86% 46.85% -0.01%
===========================================
Files 707 707
Lines 13234 13234
Branches 2217 2217
===========================================
- Hits 6202 6201 -1
- Misses 6719 6720 +1
Partials 313 313
Flags with carried forward coverage won't be shown. Click here to find out more. |
geekgonecrazy
approved these changes
May 18, 2023
dionisio-bot
bot
added
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
May 23, 2023
…memberList * 'develop' of github.com:RocketChat/Rocket.Chat: (72 commits) fix: respect useEmoji pref on messages (#28975) chore: Move 2fa challenge handler to rest api package (#29263) refactor(integrations): Replace Fibers dependency by Deasync (#29081) chore: improve server stream typings (#29128) fix: Livechat `CSP` whitelist validation (#29278) chore: `ListItem` stories (#29251) regression(push): fix error when adding headers to send push notification (#29287) fix: Handle login services errors (#28795) chore: skip hook if HUSKY env var is set to 0 (#29283) ci: skip husky hooks on ci (#29279) chore: Add `roomName` on Composer placeholder (#29255) regression: fix console warnings (#29277) ci: fix Release Task chore: Add Changesets (#29275) feat(Marketplace): Scroll to the top of the marketplace apps list when page changed (#29095) fix: Members/Channels list infinite scroll (#28636) test: use local httpbin container on github CI's (#29067) Bump vm2 version 3.9.19 (#29258) i18n: Language update from LingoHub 🤖 on 2023-05-16Z (#29252) chore: Composer missing scrollbar color (#29256) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments