fix: OTR session closing after 10 seconds without warning #29245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #29245 +/- ##
===========================================
+ Coverage 45.76% 45.89% +0.13%
===========================================
Files 685 685
Lines 12984 12988 +4
Branches 2208 2209 +1
===========================================
+ Hits 5942 5961 +19
+ Misses 6732 6719 -13
+ Partials 310 308 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
🦋 Changeset detectedLatest commit: 59414c0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dionisio-bot
bot
added
the
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
ggazzo
approved these changes
May 31, 2023
This was referenced May 31, 2023
gabriellsh
added a commit
that referenced
this pull request
Jun 1, 2023
…e/system-messages-update * 'develop' of github.com:RocketChat/Rocket.Chat: (26 commits) fix: Importer crashes when sending the "active status" e-mail notification to users (#29401) docs: new README file (#27955) refactor: replace with new `Select` (#29368) fix: Sidebar's sort by name not being checked properly (#29415) fix: Login Terms custom content (#28999) fix: Broken link fixed inside webhook menu (#29048) fix: Apps settings i18n translation (#29394) fix: OTR session closing after 10 seconds without warning (#29245) fix: Register Username form showing before homepage (#29356) regression(ui-client): Toolbox action button badge in the wrong position (#29412) fix: marketplace filters are changing size (#28738) chore: Update highlighted word color (#29407) i18n: Language update from LingoHub 🤖 on 2023-05-22Z (#29317) chore(ddp-sdk): ts-jest -> swc/jest (#29380) chore: `ToolboxAction` pressed state (#29397) chore: add logs to recurring omnichannel cron jobs (#29392) regression: `t` using always sprintf (#29396) fix: fix wrong %s translations (#29395) regression(push): fix error when selecting what to import (#29289) chore: Change ddpsdk.stream to return subscription (#29375) ...
sampaiodiego
pushed a commit
that referenced
this pull request
Jun 1, 2023
sampaiodiego
pushed a commit
that referenced
this pull request
Jun 1, 2023
This was referenced Jun 4, 2023
aleksandernsilva
pushed a commit
that referenced
this pull request
Jun 6, 2023
This was referenced Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
The
Notificationsstreamer is sending two events when there's a license applied to the workspace and it's not using Microservices. I'm avoiding this by simply ignoring the second event in OTRRoom.There is still an issue where there's 2 system messages being fired after accepting, but that's not a really big concern since it doesn't break anything.
Issue(s)
SUP-224
Steps to test or reproduce
Apply a license to the workspace
Start an OTR session with another user.
The other user will receive a notification (modal) asking to accept the session. Counting from the time the modal shows up, even if accepted, 10 seconds later the OTR session will timeout.
Further comments