Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression: AppRow bundleIn verification #31373

Merged
merged 1 commit into from
Jan 4, 2024
Merged

regression: AppRow bundleIn verification #31373

merged 1 commit into from
Jan 4, 2024

Conversation

juliajforesti
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 4, 2024

⚠️ No Changeset found

Latest commit: 3217ff0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov Codecov
Copy link

codecov bot commented Jan 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0da7423) 49.33% compared to head (3217ff0) 49.33%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #31373   +/-   ##
========================================
  Coverage    49.33%   49.33%           
========================================
  Files         3310     3310           
  Lines        81343    81343           
  Branches     16659    16659           
========================================
+ Hits         40132    40134    +2     
- Misses       36506    36507    +1     
+ Partials      4705     4702    -3
Flag Coverage Δ
e2e 52.51% <ø> (-0.02%) ⬇️
e2e-api 40.65% <ø> (+0.01%) ⬆️
unit 76.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jan 4, 2024
@juliajforesti juliajforesti marked this pull request as ready for review January 4, 2024 15:01
@juliajforesti juliajforesti requested a review from a team as a code owner January 4, 2024 15:01
@kodiakhq kodiakhq bot merged commit 8677f15 into develop Jan 4, 2024
47 checks passed
@kodiakhq kodiakhq bot deleted the fix/appRow branch January 4, 2024 15:01
gabriellsh added a commit that referenced this pull request Jan 5, 2024
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into new/…
37fcb71 
…hideUi

* 'develop' of github.com:RocketChat/Rocket.Chat:
  chore: add gitpod config file for quick setup (#30921)
  feat: Allow user to set timeout of outgoing webhook (#31222)
  feat: added modal confirmation before pinning message (#31348)
  fix: not being able to access or create rooms with join code (#31270)
  chore: services changes on lifecycle methods + throw if svc is not available (#31375)
  test: bump playwright (#31376)
  i18n: update translations (#29462)
  i18n: adds video call translations for Persian language (#30406)
  regression: `AppRow` bundleIn verification (#31373)
  feat: Add Desktop PDF viewer (#31279)
  fix: Attachments not collapsing when using incoming webhook (#31318)
  chore: add aria-label to Select Inputs at Engagement Dashboard (#31249)
  fix: engagement dashboard timezone selector (#31248)
@geekgonecrazy
Copy link
Contributor

geekgonecrazy commented Jan 11, 2024 •
edited
Loading

We should potentially change the title as this one effected 6.5 not just develop. So is more of a fix then regression

@dougfabris dougfabris changed the title regression: AppRow bundleIn verification fix: AppRow bundleIn verification Jan 11, 2024
@dougfabris dougfabris mentioned this pull request Jan 12, 2024
Merged
@casalsgh casalsgh added this to the 6.6 milestone Jan 12, 2024
@dougfabris dougfabris changed the title fix: AppRow bundleIn verification regression: AppRow bundleIn verification Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougfabris dougfabris dougfabris approved these changes

Assignees
No one assigned
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
6.6
Development

Successfully merging this pull request may close these issues.
4 participants
@juliajforesti @geekgonecrazy @dougfabris @casalsgh