Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: UiKitMessage refreshing room #31603

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

hugocostadev
Copy link
Contributor

@hugocostadev hugocostadev commented Feb 1, 2024

Proposed changes (including videos or screenshots)

The UiKitMessage was blinking/refreshing the room page due to an action that it was triggering the Suspense, to fix it I've added an inner suspense before the UiKitMessage

Issue(s)

Steps to test or reproduce

Further comments

TC-1099

@hugocostadev hugocostadev added this to the 6.6 milestone Feb 1, 2024
@hugocostadev hugocostadev requested a review from a team as a code owner February 1, 2024 15:16
Copy link

changeset-bot bot commented Feb 1, 2024

⚠️ No Changeset found

Latest commit: 1c04414

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ead0907) 49.56% compared to head (1c04414) 49.54%.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-6.6.0   #31603      +/-   ##
=================================================
- Coverage          49.56%   49.54%   -0.02%     
=================================================
  Files               3326     3322       -4     
  Lines              81796    81743      -53     
  Branches           16881    16872       -9     
=================================================
- Hits               40539    40501      -38     
+ Misses             36518    36506      -12     
+ Partials            4739     4736       -3     
Flag Coverage Δ
e2e 53.25% <ø> (-0.01%) ⬇️
e2e-api 40.63% <ø> (-0.03%) ⬇️
unit 76.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo force-pushed the regression/UiKitMessage-refresh-room branch from 8797835 to 8e3011d Compare February 1, 2024 15:24
@hugocostadev hugocostadev requested review from a team as code owners February 1, 2024 15:24
@ggazzo ggazzo changed the base branch from develop to release-6.6.0 February 1, 2024 15:24
@hugocostadev hugocostadev reopened this Feb 1, 2024
@ggazzo ggazzo force-pushed the regression/UiKitMessage-refresh-room branch from 8e3011d to 1c04414 Compare February 1, 2024 15:27
@ggazzo ggazzo merged commit 97080a3 into release-6.6.0 Feb 1, 2024
43 checks passed
@ggazzo ggazzo deleted the regression/UiKitMessage-refresh-room branch February 1, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants