-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: Improve permissions check on misc endpoints #32337
chore!: Improve permissions check on misc endpoints #32337
Conversation
Co-authored-by: Diego Sampaio <chinello@gmail.com>
Looks like this PR is ready to merge! 🎉 |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.0.0 #32337 +/- ##
================================================
Coverage ? 55.52%
================================================
Files ? 2405
Lines ? 52926
Branches ? 10872
================================================
Hits ? 29385
Misses ? 20933
Partials ? 2608
Flags with carried forward coverage won't be shown. Click here to find out more. |
Co-authored-by: Diego Sampaio <chinello@gmail.com>
* chore: Improve permission check on channels endpoints
Proposed changes (including videos or screenshots)
misc
endpoints by using thepermissionsRequired
property.Issue(s)
CORE-392
Steps to test or reproduce
Further comments
The intention for this PR is to improve code readability and make unauthorized erros more standardized. No side effects are expected. We're considering this a breaking change since unauthorized errors are being changed to follow the same standard when possible.