Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Improve permissions check on roles endpoints #32347

Merged
merged 59 commits into from May 20, 2024

Conversation

matheusbsilva137
Copy link
Contributor

@matheusbsilva137 matheusbsilva137 commented Apr 30, 2024

Proposed changes (including videos or screenshots)

  • Improve permissions check on roles endpoints by using the permissionsRequired property.

Issue(s)

CORE-346

Steps to test or reproduce

Further comments

The intention for this PR is to improve code readability and make unauthorized erros more standardized. No side effects are expected. We're considering this a breaking change since unauthorized errors are being changed to follow the same standard when possible.

@matheusbsilva137 matheusbsilva137 added this to the 7.0 milestone Apr 30, 2024
Copy link
Contributor

dionisio-bot bot commented Apr 30, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Apr 30, 2024

⚠️ No Changeset found

Latest commit: 9ebfc76

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.56%. Comparing base (d2530d3) to head (9ebfc76).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-7.0.0   #32347      +/-   ##
=================================================
- Coverage          55.56%   55.56%   -0.01%     
=================================================
  Files               2408     2410       +2     
  Lines              53019    53074      +55     
  Branches           10902    10909       +7     
=================================================
+ Hits               29460    29488      +28     
- Misses             20941    20963      +22     
- Partials            2618     2623       +5     
Flag Coverage Δ
e2e 55.02% <ø> (-0.03%) ⬇️
unit 72.91% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@matheusbsilva137 matheusbsilva137 marked this pull request as ready for review May 16, 2024 16:06
@matheusbsilva137 matheusbsilva137 requested a review from a team as a code owner May 16, 2024 16:06
KevLehman
KevLehman previously approved these changes May 17, 2024
@matheusbsilva137 matheusbsilva137 added the stat: QA assured Means it has been tested and approved by a company insider label May 20, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 20, 2024
@matheusbsilva137 matheusbsilva137 merged commit bba2a7e into release-7.0.0 May 20, 2024
49 of 50 checks passed
@matheusbsilva137 matheusbsilva137 deleted the chore/permissions-check-roles branch May 20, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants