-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Modals opened by apps won't close when executeViewCloseHandler
is not implemented
#32374
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 9964572 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-6.8.0 #32374 +/- ##
=================================================
- Coverage 55.41% 54.32% -1.09%
=================================================
Files 2370 2294 -76
Lines 52094 50991 -1103
Branches 10653 10442 -211
=================================================
- Hits 28868 27701 -1167
- Misses 20707 20832 +125
+ Partials 2519 2458 -61
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this bump do? It seems to me that it's a fix, could you add a changeset explaining what it fixes? otherwise people won't know what was fixed
@rocket.chat/apps-engine
versionexecuteViewCloseHandler
is not implemented
rocketchat.atlassian.net/browse/CORE-401
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
Fixes an issue with some apps that didn't implement executeViewCloseHandler. This causes opened modals to be open forever on UI. This is because when the UI attempts to close it, it calls the aforementioned handler, and since it didn't exist, apps engine errored out.
This returned an empty response to the UI, which ignored the response and continued to show the view.