Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Modals opened by apps won't close when executeViewCloseHandler is not implemented #32374

Merged
merged 3 commits into from
May 7, 2024

Conversation

KevLehman
Copy link
Contributor

@KevLehman KevLehman commented May 6, 2024

rocketchat.atlassian.net/browse/CORE-401

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Fixes an issue with some apps that didn't implement executeViewCloseHandler. This causes opened modals to be open forever on UI. This is because when the UI attempts to close it, it calls the aforementioned handler, and since it didn't exist, apps engine errored out.

This returned an empty response to the UI, which ignored the response and continued to show the view.

Copy link
Contributor

dionisio-bot bot commented May 6, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented May 6, 2024

🦋 Changeset detected

Latest commit: 9964572

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/core-typings Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/rest-typings Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/ddp-client Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@KevLehman KevLehman marked this pull request as ready for review May 6, 2024 13:29
@KevLehman KevLehman requested review from a team as code owners May 6, 2024 13:29
Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.32%. Comparing base (048a977) to head (60ee12f).
Report is 1 commits behind head on release-6.8.0.

❗ Current head 60ee12f differs from pull request most recent head 9964572. Consider uploading reports for the commit 9964572 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-6.8.0   #32374      +/-   ##
=================================================
- Coverage          55.41%   54.32%   -1.09%     
=================================================
  Files               2370     2294      -76     
  Lines              52094    50991    -1103     
  Branches           10653    10442     -211     
=================================================
- Hits               28868    27701    -1167     
- Misses             20707    20832     +125     
+ Partials            2519     2458      -61     
Flag Coverage Δ
e2e 52.65% <ø> (-2.06%) ⬇️
unit 75.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot added stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA tested labels May 6, 2024
@scuciatto scuciatto added this to the 6.8 milestone May 6, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 6, 2024
Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this bump do? It seems to me that it's a fix, could you add a changeset explaining what it fixes? otherwise people won't know what was fixed

AllanPazRibeiro
AllanPazRibeiro previously approved these changes May 7, 2024
@KevLehman KevLehman changed the title chore: Bump @rocket.chat/apps-engine version fix: Modals opened by apps won't close when executeViewCloseHandler is not implemented May 7, 2024
@KevLehman KevLehman requested a review from ggazzo May 7, 2024 13:55
@kodiakhq kodiakhq bot merged commit b94ca7c into release-6.8.0 May 7, 2024
10 of 11 checks passed
@kodiakhq kodiakhq bot deleted the fix/apps-engine-bump branch May 7, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants