Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new NavBar #32382

Closed
wants to merge 70 commits into from
Closed

feat: new NavBar #32382

wants to merge 70 commits into from

Conversation

juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented May 7, 2024

SIDE-35

epic tasks:

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented May 7, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is targeting the wrong base branch. It should target 6.11.0, but it targets 6.10.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented May 7, 2024

⚠️ No Changeset found

Latest commit: 3d977f3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 77.06422% with 50 lines in your changes missing coverage. Please review.

Project coverage is 52.22%. Comparing base (560520c) to head (3d977f3).

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           feat/new-navigation   #32382      +/-   ##
=======================================================
- Coverage                56.72%   52.22%   -4.51%     
=======================================================
  Files                     2499     2107     -392     
  Lines                    55380    49117    -6263     
  Branches                 11461    10068    -1393     
=======================================================
- Hits                     31416    25652    -5764     
+ Misses                   21258    21189      -69     
+ Partials                  2706     2276     -430     
Flag Coverage Δ
e2e 46.99% <75.58%> (-9.51%) ⬇️
unit 71.76% <88.57%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@juliajforesti juliajforesti changed the title feat: new navigation with NavBar feat: new NavBar Jun 25, 2024
@casalsgh casalsgh modified the milestones: 6.10, 6.11 Jun 27, 2024
@juliajforesti juliajforesti force-pushed the feat/new-navigation branch 3 times, most recently from c2e6e2f to 6c1d08e Compare July 4, 2024 21:40
Base automatically changed from feat/new-navigation to develop July 12, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants