Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: EditRoomInfo encrypted field placement #32458

Merged
merged 10 commits into from
Jun 22, 2024
Merged

Conversation

juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented May 20, 2024

CORE-460

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented May 20, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented May 20, 2024

🦋 Changeset detected

Latest commit: b5101e9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.52%. Comparing base (e47ae76) to head (b5101e9).
Report is 3 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32458      +/-   ##
===========================================
- Coverage    56.62%   56.52%   -0.11%     
===========================================
  Files         2486     2487       +1     
  Lines        54921    54994      +73     
  Branches     11364    11377      +13     
===========================================
- Hits         31097    31083      -14     
- Misses       21151    21234      +83     
- Partials      2673     2677       +4     
Flag Coverage Δ
e2e 56.15% <100.00%> (-0.05%) ⬇️
unit 71.71% <ø> (-0.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@juliajforesti juliajforesti marked this pull request as ready for review May 20, 2024 17:38
@juliajforesti juliajforesti requested a review from a team as a code owner May 20, 2024 17:38
@dougfabris dougfabris modified the milestones: 6.9, 6.10 May 20, 2024
@ggazzo ggazzo force-pushed the fix/edit-room-encrypted-field branch from 77b235e to 18057e4 Compare June 21, 2024 03:32
@dougfabris dougfabris marked this pull request as draft June 21, 2024 18:01
@dougfabris dougfabris force-pushed the fix/edit-room-encrypted-field branch from 8079d19 to 95552e1 Compare June 21, 2024 18:52
@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Jun 21, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 21, 2024
@dougfabris dougfabris marked this pull request as ready for review June 21, 2024 18:53
@ggazzo ggazzo merged commit 9fe05d3 into develop Jun 22, 2024
50 checks passed
@ggazzo ggazzo deleted the fix/edit-room-encrypted-field branch June 22, 2024 03:03
This was referenced Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants