refactor!: removed roomNameExists method

[abhinavkrin]

Proposed changes (including videos or screenshots)

Removed roomNameExists method as it has been replaced by rooms.nameExists endpoint

Issue(s)

Steps to test or reproduce

Further comments

CORE-351

[dionisio-bot]

Looks like this PR is not ready to merge, because of the following issues:

• This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

[changeset-bot]

⚠️ No Changeset found

Latest commit: 6a29f0a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.56%. Comparing base (bba2a7e) to head (6a29f0a).

Additional details and impacted files

@@                Coverage Diff                @@
##           release-7.0.0   #32484      +/-   ##
=================================================
- Coverage          55.59%   55.56%   -0.04%     
=================================================
  Files               2427     2408      -19     
  Lines              53337    53019     -318     
  Branches           10970    10902      -68     
=================================================
- Hits               29651    29458     -193     
+ Misses             21050    20946     -104     
+ Partials            2636     2615      -21     

Flag	Coverage Δ
e2e	55.03% <ø> (-0.11%)	⬇️
unit	72.88% <ø> (+0.14%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[MarcosSpessatto]

Can we take a look at this test case? I think there's something weird since it's expecting an error when no room is found...

https://github.com/RocketChat/Rocket.Chat/blob/develop/apps/meteor/tests/end-to-end/api/09-rooms.js#L425

[abhinavkrin]

Can we take a look at this test case? I think there's something weird since it's expecting an error when no room is found...

https://github.com/RocketChat/Rocket.Chat/blob/develop/apps/meteor/tests/end-to-end/api/09-rooms.js#L425

I looked at it, the test was for an invalid roomId which should not be there as we dont accept a roomId for this endpoint.
So I changed this test to check for invalid params which makes the test more clear.
Also, I added a test to check if false is returned if roomName is not found.

The merge-base changed after approval.