Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow remove cache on application error #32487

Merged
merged 2 commits into from
Jul 7, 2024

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented May 24, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented May 24, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is targeting the wrong base branch. It should target 6.10.0, but it targets 6.9.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented May 24, 2024

⚠️ No Changeset found

Latest commit: 309f807

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.28%. Comparing base (c6450b1) to head (309f807).
Report is 127 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32487      +/-   ##
===========================================
+ Coverage    56.22%   56.28%   +0.06%     
===========================================
  Files         2425     2444      +19     
  Lines        53522    54225     +703     
  Branches     11024    11201     +177     
===========================================
+ Hits         30093    30521     +428     
- Misses       20806    21090     +284     
+ Partials      2623     2614       -9     
Flag Coverage Δ
unit 71.98% <ø> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo marked this pull request as ready for review May 27, 2024 12:55
@ggazzo ggazzo requested a review from a team as a code owner May 27, 2024 12:55
@ggazzo ggazzo added this to the 6.10 milestone May 27, 2024
rodrigok
rodrigok previously approved these changes Jul 5, 2024
@ggazzo ggazzo merged commit b7deefa into develop Jul 7, 2024
18 checks passed
@ggazzo ggazzo deleted the chore/reload-on-error-delete-dv branch July 7, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants