Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Widen types for message rendering helpers #32601

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Jun 13, 2024

Proposed changes (including videos or screenshots)

This PR tightens some function signatures from functions that used to receive complete IMessage objects but now only operate on message's text content. The goal of it is to improve type-safety a little bit.

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jun 13, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is targeting the wrong base branch. It should target 6.11.0, but it targets 6.10.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jun 13, 2024

⚠️ No Changeset found

Latest commit: d251cfc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.48%. Comparing base (3039968) to head (d251cfc).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32601      +/-   ##
===========================================
- Coverage    56.53%   56.48%   -0.06%     
===========================================
  Files         2484     2484              
  Lines        54693    54723      +30     
  Branches     11286    11297      +11     
===========================================
- Hits         30921    30908      -13     
- Misses       21122    21128       +6     
- Partials      2650     2687      +37     
Flag Coverage Δ
e2e 56.10% <80.00%> (-0.07%) ⬇️
e2e-api 41.29% <ø> (-0.04%) ⬇️
unit 72.18% <60.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan force-pushed the refactor/msg-helpers-signatures branch 6 times, most recently from c477b91 to f8a8765 Compare June 18, 2024 15:07
@tassoevan tassoevan force-pushed the refactor/msg-helpers-signatures branch from f8a8765 to d251cfc Compare June 18, 2024 23:57
@tassoevan tassoevan marked this pull request as ready for review June 19, 2024 00:00
@tassoevan tassoevan requested a review from a team as a code owner June 19, 2024 00:00
@tassoevan tassoevan modified the milestones: 6.10, 7.0 Jun 24, 2024
@casalsgh casalsgh modified the milestones: 7.0, 6.11 Jun 24, 2024
@ggazzo ggazzo merged commit 6f935c8 into develop Jun 24, 2024
50 checks passed
@ggazzo ggazzo deleted the refactor/msg-helpers-signatures branch June 24, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants