Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: remove deprecated meteor eraseRoom method #32648

Merged
merged 2 commits into from
Aug 17, 2024

Conversation

AllanPazRibeiro
Copy link
Contributor

@AllanPazRibeiro AllanPazRibeiro commented Jun 20, 2024

Proposed changes (including videos or screenshots)

This PR removes the eraseRoom to use the room.delete endpoint

Issue(s)

CORE-350

Steps to test or reproduce

Further comments

@AllanPazRibeiro AllanPazRibeiro self-assigned this Jun 20, 2024
@AllanPazRibeiro AllanPazRibeiro requested a review from a team as a code owner June 20, 2024 19:39
Copy link
Contributor

dionisio-bot bot commented Jun 20, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jun 20, 2024

🦋 Changeset detected

Latest commit: b9ec018

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/ddp-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@AllanPazRibeiro AllanPazRibeiro added this to the 7.0 milestone Jun 20, 2024
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.39%. Comparing base (8c447cf) to head (b9ec018).
Report is 1 commits behind head on release-7.0.0.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-7.0.0   #32648   +/-   ##
==============================================
  Coverage          59.39%   59.39%           
==============================================
  Files               2541     2541           
  Lines              63175    63175           
  Branches           14220    14220           
==============================================
  Hits               37525    37525           
  Misses             22935    22935           
  Partials            2715     2715           
Flag Coverage Δ
unit 76.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@abhinavkrin abhinavkrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also move away from using Meteor.Error in the eraseRoom function and instead use Error object. This will be a step from moving away from meteor. Wdys?

intead of

throw new Meteor.Error('error-invalid-room', 'Invalid room', {

using

throw new Error('error-invalid-room')

@ggazzo
Copy link
Member

ggazzo commented Aug 15, 2024

I think we should also move away from using Meteor.Error in the eraseRoom function and instead use Error object. This will be a step from moving away from meteor. Wdys?

intead of

throw new Meteor.Error('error-invalid-room', 'Invalid room', {

using

throw new Error('error-invalid-room')

Meteor error and Error are handled differently by the api, Error is not exposed to final users.

@ggazzo ggazzo force-pushed the refactor/SUP-350/removing-eraseroom-method branch from 2d06f5e to f90fe83 Compare August 15, 2024 20:22
@ggazzo ggazzo requested review from a team as code owners August 15, 2024 20:22
ggazzo
ggazzo previously approved these changes Aug 15, 2024
@ggazzo ggazzo force-pushed the refactor/SUP-350/removing-eraseroom-method branch 3 times, most recently from f90fe83 to 15fee1e Compare August 16, 2024 17:39
@ggazzo ggazzo force-pushed the refactor/SUP-350/removing-eraseroom-method branch from 15fee1e to e5c6788 Compare August 16, 2024 17:40
@ggazzo ggazzo changed the base branch from develop to release-7.0.0 August 16, 2024 17:40
ggazzo
ggazzo previously approved these changes Aug 16, 2024
@ggazzo ggazzo changed the title refactor: remove deprecated meteor eraseRoom method chore!: remove deprecated meteor eraseRoom method Aug 16, 2024
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Aug 16, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 16, 2024
@ggazzo ggazzo force-pushed the refactor/SUP-350/removing-eraseroom-method branch from 8c7752a to b9ec018 Compare August 16, 2024 22:15
@ggazzo ggazzo merged commit 14fd023 into release-7.0.0 Aug 17, 2024
49 checks passed
@ggazzo ggazzo deleted the refactor/SUP-350/removing-eraseroom-method branch August 17, 2024 00:32
ggazzo added a commit that referenced this pull request Sep 5, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Sep 11, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Sep 13, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Sep 13, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Sep 14, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Sep 16, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
MartinSchoeler pushed a commit that referenced this pull request Sep 18, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Sep 25, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Sep 25, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Sep 27, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Sep 27, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Oct 8, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
sampaiodiego pushed a commit that referenced this pull request Oct 9, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
sampaiodiego pushed a commit that referenced this pull request Oct 9, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
abhinavkrin pushed a commit that referenced this pull request Oct 11, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Oct 11, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Oct 11, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Oct 11, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Oct 11, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Oct 14, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
MartinSchoeler pushed a commit that referenced this pull request Oct 14, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Oct 15, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Oct 17, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Oct 17, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
This was referenced Oct 20, 2024
abhinavkrin pushed a commit that referenced this pull request Oct 25, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Nov 6, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Nov 6, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants