Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: changed core location service property names #231

Merged
merged 1 commit into from
Dec 2, 2023
Merged

chore: changed core location service property names #231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions src/Apple/Locations/CoreLocationManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,36 +32,36 @@ public CoreLocationManager()
handler => _locationManager.Value.DeferredUpdatesFinished -= handler)
.Select(LocationEventExtensions.ToNotification);

DidDetermineState =
DeterminedState =
Observable
.FromEvent<EventHandler<CLRegionStateDeterminedEventArgs>, CLRegionStateDeterminedEventArgs>(
handler => _locationManager.Value.DidDetermineState += handler,
handler => _locationManager.Value.DidDetermineState -= handler)
.Select(LocationEventExtensions.ToNotification);

DidFailRangingBeacons =
FailedRangingBeacons =
Observable
.FromEvent<EventHandler<CLRegionBeaconsConstraintFailedEventArgs>,
CLRegionBeaconsConstraintFailedEventArgs>(
handler => _locationManager.Value.DidFailRangingBeacons += handler,
handler => _locationManager.Value.DidFailRangingBeacons -= handler)
.Select(LocationEventExtensions.ToNotification);

DidRangeBeaconsSatisfyingConstraint =
RangedBeaconsSatisfyingConstraint =
Observable
.FromEvent<EventHandler<CLRegionBeaconsConstraintRangedEventArgs>, CLRegionBeaconsConstraintRangedEventArgs>(
handler => _locationManager.Value.DidRangeBeaconsSatisfyingConstraint += handler,
handler => _locationManager.Value.DidRangeBeaconsSatisfyingConstraint -= handler)
.Select(LocationEventExtensions.ToNotification);

DidStartMonitoringForRegion =
StartedMonitoringForRegion =
Observable
.FromEvent<EventHandler<CLRegionEventArgs>, CLRegionEventArgs>(
handler => _locationManager.Value.DidStartMonitoringForRegion += handler,
handler => _locationManager.Value.DidStartMonitoringForRegion -= handler)
.Select(LocationEventExtensions.ToNotification);

DidVisit =
Visited =
Observable
.FromEvent<EventHandler<CLVisitedEventArgs>, CLVisitedEventArgs>(
handler => _locationManager.Value.DidVisit += handler,
Expand Down Expand Up @@ -136,19 +136,19 @@ public CoreLocationManager()
public IObservable<ErrorEvent> DeferredUpdatesFinished { get; }

/// <inheritdoc />
public IObservable<RegionChangedEvent> DidDetermineState { get; }
public IObservable<RegionChangedEvent> DeterminedState { get; }

/// <inheritdoc />
public IObservable<RegionBeaconsConstraintFailedEvent> DidFailRangingBeacons { get; }
public IObservable<RegionBeaconsConstraintFailedEvent> FailedRangingBeacons { get; }

/// <inheritdoc />
public IObservable<RegionBeaconsConstraintRangedEvent> DidRangeBeaconsSatisfyingConstraint { get; }
public IObservable<RegionBeaconsConstraintRangedEvent> RangedBeaconsSatisfyingConstraint { get; }

/// <inheritdoc />
public IObservable<RegionChangedEvent> DidStartMonitoringForRegion { get; }
public IObservable<RegionChangedEvent> StartedMonitoringForRegion { get; }

/// <inheritdoc />
public IObservable<VisitedEvent> DidVisit { get; }
public IObservable<VisitedEvent> Visited { get; }

/// <inheritdoc />
public IObservable<ErrorEvent> Failed { get; }
Expand Down
10 changes: 5 additions & 5 deletions src/Core/Locations/ICoreLocationService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,27 +21,27 @@ public interface ICoreLocationService
/// <summary>
/// Gets an observable sequence of notifications when region state is determined.
/// </summary>
IObservable<RegionChangedEvent> DidDetermineState { get; }
IObservable<RegionChangedEvent> DeterminedState { get; }

/// <summary>
/// Gets an observable sequence of region beacon failure notifications.
/// </summary>
IObservable<RegionBeaconsConstraintFailedEvent> DidFailRangingBeacons { get; }
IObservable<RegionBeaconsConstraintFailedEvent> FailedRangingBeacons { get; }

/// <summary>
/// Gets an observable sequence of beacon range constraint notifications.
/// </summary>
IObservable<RegionBeaconsConstraintRangedEvent> DidRangeBeaconsSatisfyingConstraint { get; }
IObservable<RegionBeaconsConstraintRangedEvent> RangedBeaconsSatisfyingConstraint { get; }

/// <summary>
/// Gets an observable sequence of regions when the are started being monitored.
/// </summary>
IObservable<RegionChangedEvent> DidStartMonitoringForRegion { get; }
IObservable<RegionChangedEvent> StartedMonitoringForRegion { get; }

/// <summary>
/// Gets an observable sequence of regions visited.
/// </summary>
IObservable<VisitedEvent> DidVisit { get; }
IObservable<VisitedEvent> Visited { get; }

/// <summary>
/// Gets an observable sequence of failure notifications.
Expand Down
Loading