New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type hints to all GDScript files #30
Comments
I try to add types when modifying the code, but I started this project before types became available in Godot. I'm a C/C++ developper when I don't use Godot, so I'm kinda okayish with strong typing. ;) |
Calinou
added a commit
to Calinou/material-maker
that referenced
this issue
Oct 20, 2019
This also simplifies some functions. This partially addresses RodZill4#30.
Calinou
added a commit
to Calinou/material-maker
that referenced
this issue
Oct 20, 2019
This also simplifies some functions. This partially addresses RodZill4#30.
RodZill4
added a commit
that referenced
this issue
Nov 6, 2019
I grep'd all missing return types and it seems the remaining ones cannot be fixed. Let's close this now (and be a bit more careful in the future). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The codebase currently has some type hints, but many of them are missing (especially for function return types).
If you'd like, I could go through the codebase and add them. I just need to know whether you're OK with type inference (
:=
). I personally prefer using it, but I know some people don't 🙂The text was updated successfully, but these errors were encountered: