Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add return type hints to all scripts #34

Merged
merged 2 commits into from Oct 21, 2019
Merged

Add return type hints to all scripts #34

merged 2 commits into from Oct 21, 2019

Conversation

Calinou
Copy link
Contributor

@Calinou Calinou commented Oct 20, 2019

This also simplifies some functions.

This partially addresses #30.

@Calinou
Copy link
Contributor Author

Calinou commented Oct 20, 2019 •
edited

This introduces some bugs due to some functions expecting null instead of an empty Dictionary, I'll look at fixing them.

@Calinou
Add return type hints to all scripts
93c8465 
This also simplifies some functions.

This partially addresses RodZill4#30.
@Calinou
Copy link
Contributor Author

Calinou commented Oct 20, 2019

Should be fixed now 🙂

@RodZill4 RodZill4 merged commit 448287d into RodZill4:export_plugin Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Calinou @RodZill4