Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor tweaks #4

Open
wants to merge 44 commits into
base: master
Choose a base branch
from
Open

Minor tweaks #4

wants to merge 44 commits into from

Conversation

glemsom
Copy link

@glemsom glemsom commented Aug 5, 2019

  • Use specific Ubuntu version (as per Dockerfile best practice)
  • Use version variable in Dockerfile
  • Rework required gamefiles
  • Consolidate volumes
  • Add run script to create default gamefiles

@Roemer
Copy link
Owner

Roemer commented Aug 13, 2019

Thank you for the PR. The change to one volume is breaking, so that should be noted in the readme somewhere. Also there are some non-generic strings around, especially in the run script :)
Can you update the PR, also fix the new conflicts?
Thanks

@Roemer
Copy link
Owner

Roemer commented Sep 10, 2019

Bump
Can you check my previous comment? I still would like to have that merged as I like the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glemsom @Roemer