Fedex #49
Merged
Fedex #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
added 3 commits
July 27, 2022 14:50
yushni
reviewed
Jul 29, 2022
| Scope string `json:"scope"` | ||
| } | ||
|
|
||
| type Error struct { |
There was a problem hiding this comment.
Мені здається, шо ті всі структури можуть сміло бути приватні.
Чи я шось упустив?
Переглянь будь ласка, всі стурктури, які є і постав їм правильну зону видимості.
Як можуть бути приватні, роби їх приватними)
There was a problem hiding this comment.
Ні не можуть, тільки структури самого верхнього рівня можуть бути приватні.
Інакше не зможе працювати пакет який джейсон мапить на структуру
added 4 commits
July 29, 2022 12:15
yushni
reviewed
Aug 1, 2022
yushni
reviewed
Aug 1, 2022
added 2 commits
August 1, 2022 13:31
yushni
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.