Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#42 prepared nova code for smooth install #47

Merged
merged 7 commits into from
Sep 25, 2023
Merged

Conversation

Adil9994
Copy link
Contributor

No description provided.

@Adil9994 Adil9994 requested a review from DenTray March 17, 2023 15:28
@DenTray
Copy link
Collaborator

DenTray commented Mar 21, 2023

@Adil9994 as discussed, we no need to install Nova to empty project, just prepare project to installation

@DenTray DenTray removed their request for review March 21, 2023 13:34
@Adil9994 Adil9994 assigned DenTray and unassigned Adil9994 May 31, 2023
@DenTray DenTray assigned Goodmain and unassigned DenTray Jun 2, 2023
# Conflicts:
#	.env.ci-testing
@Goodmain
Copy link
Contributor

@DenTray I resolved conflicts. Please check again

@Goodmain Goodmain assigned DenTray and unassigned Goodmain Sep 17, 2023
Copy link
Collaborator

@DenTray DenTray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Goodmain could you please refine whether we should keep migration class and composer change here?

@DenTray DenTray assigned Goodmain and unassigned DenTray Sep 18, 2023
@Goodmain
Copy link
Contributor

@DenTray I removed migration and auth config file changes related to the reset_passwords table.

@Goodmain Goodmain assigned DenTray and unassigned Goodmain Sep 19, 2023
composer.json Outdated Show resolved Hide resolved
@DenTray DenTray merged commit 4f11036 into development Sep 25, 2023
@DenTray DenTray deleted the 42-prepare-nova branch October 15, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants