Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update description generating logic #49

Closed
DenTray opened this issue Jun 27, 2022 · 5 comments
Closed

Update description generating logic #49

DenTray opened this issue Jun 27, 2022 · 5 comments
Assignees
@DenTray
Labels
state: ready to version type: enhancement
Milestone
2.2

Comments

@DenTray
Copy link
Collaborator

DenTray commented Jun 27, 2022

  1. All type-related validation rules should be skiped
  2. required validation rule should be skipped, it already mark field with * symbol
  3. If there is no required or present validation rule - field should be marked as "Optional"
  4. Description should be started from the annotation or attributes method (annotation will be prioritized)
@DenTray DenTray mentioned this issue Jun 27, 2022
Closed
pirs1337 added a commit that referenced this issue Jul 16, 2022
@pirs1337
feat: update description generating logic;
7283f5b 
Refs: #49
@pirs1337 pirs1337 mentioned this issue Jul 16, 2022
Merged
pirs1337 added a commit that referenced this issue Jul 18, 2022
@pirs1337
refactor: refactoring to remove useless keys;
335a5f7 
Refs: #49
pirs1337 added a commit that referenced this issue Jul 19, 2022
@pirs1337
chore: renaming rulesOfTypes property;
8bc987d 
Refs: #49
pirs1337 added a commit that referenced this issue Jul 29, 2022
@pirs1337
fix: fix description logic;
6244a5a 
Refs: #49
pirs1337 added a commit that referenced this issue Jul 29, 2022
@pirs1337
fix: fix description logic;
7d77ea6 
Refs: #49
pirs1337 added a commit that referenced this issue Jul 29, 2022
@pirs1337
fix: fix description logic;
e035b08 
Refs: #49
pirs1337 added a commit that referenced this issue Jul 30, 2022
@pirs1337
fix: fix description logic;
94d2d1c 
Refs: #49
pirs1337 added a commit that referenced this issue Jul 30, 2022
@pirs1337
chore: adding type for function parameter
fc19e94 
Refs: #49
pirs1337 added a commit that referenced this issue Aug 6, 2022
@pirs1337
fix: replacing method;
75be84d 
Refs: #49
astorozhevsky added a commit that referenced this issue Aug 8, 2022
@astorozhevsky
Merge pull request #52 from RonasIT/49_update_description_generating_…
c8675a9 
…logic

#49:- update description generating logic;
@pirs1337
Copy link
Contributor

@DenTray, you can test

@pirs1337 pirs1337 assigned DenTray and unassigned pirs1337 Aug 13, 2022
@DenTray
Copy link
Collaborator Author

DenTray commented Aug 18, 2022

@pirs1337 I've a strange numbers after the update

image

@DenTray DenTray assigned pirs1337 and unassigned DenTray Aug 18, 2022
pirs1337 added a commit that referenced this issue Aug 18, 2022
@pirs1337
fix: fix display rules;
14574c2 
Refs: #49
@pirs1337 pirs1337 mentioned this issue Aug 18, 2022
Merged
pirs1337 added a commit that referenced this issue Aug 19, 2022
@pirs1337
fix: fix display rules;
6bfb3d0 
Refs: #49
DenTray added a commit that referenced this issue Sep 14, 2022
@DenTray
Merge pull request #59 from RonasIT/49_update_description_generating_…
8ff60a5 
…logic

#49:- fix: fix display rules;
@pirs1337
Copy link
Contributor

@DenTray, ready for testing

@pirs1337 pirs1337 assigned DenTray and unassigned pirs1337 Sep 15, 2022
@DenTray
Copy link
Collaborator Author

DenTray commented Nov 3, 2022

@pirs1337 looks good now, thanks!

@DenTray DenTray added this to the 2.2 milestone Jun 20, 2023
@DenTray
Copy link
Collaborator Author

DenTray commented Nov 7, 2023

Released in 2.2 version

@DenTray DenTray closed this as completed Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DenTray DenTray

Labels
state: ready to version type: enhancement
Projects
None yet
Milestone
2.2
Development

No branches or pull requests
2 participants
@DenTray @pirs1337