Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose main site moderator IDs #3

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Nessworthy
Copy link

@Nessworthy Nessworthy commented Oct 3, 2018

Prerequisite for Room-11/Jeeves#217 - exposes site moderator usernames + IDs when calling getRoomAccess($room) in AclDataAccessor.

I wasn't sure on the place for the code, and I know the two requests could be done in parallel.

Feedback appreciated!

@Nessworthy Nessworthy changed the title Supply site moderator information when calling AclDataAccessor::getRoomAccess Expose main site moderator IDs Oct 3, 2018
@Nessworthy
Copy link
Author

Access to site moderator IDs is now from a separate method - getMainSiteModerators

Copy link
Member

@DaveRandom DaveRandom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

u ok hun?

src/Room/ChatRoomAclDataAccessor.php Outdated Show resolved Hide resolved
src/Room/ChatRoomAclDataAccessor.php Outdated Show resolved Hide resolved
.. Also remove \Amp\resolve from importing and use the FQN at runtime instead.

Thanks @DaveRandom
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants