Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Line parameters #121

Merged
merged 14 commits into from
Aug 25, 2023
Merged

Line parameters #121

merged 14 commits into from
Aug 25, 2023

Conversation

benoit9126
Copy link
Member

@benoit9126 benoit9126 commented Aug 24, 2023 •
edited
Loading

Improvements of the LineParameters class:

  • Delete the LineModel class
  • Simplify the from_dict method
  • Rename and refactor the method from_lv_exact into from_geometry.
  • Add documentation for the LineParameters alternative constructors.
  • Rename InsulationType into InsulatorType
  • Update the from_name alternative constructors
  • Delete the model from the line parameters serialization

NB: I still have some additional modifications to add

@benoit9126 benoit9126 added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 24, 2023
@benoit9126 benoit9126 self-assigned this Aug 24, 2023
@benoit9126 benoit9126 marked this pull request as ready for review August 25, 2023 08:54
@benoit9126 benoit9126 linked an issue Aug 25, 2023 that may be closed by this pull request
DOC: LineParameters alternative constructors #68
Closed
This was referenced Aug 25, 2023
Open
Closed
alihamdan
alihamdan approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@alihamdan alihamdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. It is a long awaited improvement to the line modelling documentation and usability.
Left some minor comments about some typos and suggestions.

doc/models/Line/Parameters.md Outdated Show resolved Hide resolved
doc/models/Line/Parameters.md Outdated Show resolved Hide resolved
doc/models/Line/Parameters.md Outdated Show resolved Hide resolved
doc/models/Line/Parameters.md Outdated Show resolved Hide resolved
doc/models/Line/Parameters.md Outdated Show resolved Hide resolved
doc/models/Line/Parameters.md Show resolved Hide resolved
doc/models/Line/Parameters.md
```

```{note}
The frequency used to compute $\omega$ is 50 Hz.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OT; shouldn't we look into allowing the user to define the frequency in RLF? This will be useful for american networks.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it should be done in a future release.

roseau/load_flow/models/lines/parameters.py Show resolved Hide resolved
roseau/load_flow/models/lines/parameters.py Outdated Show resolved Hide resolved
roseau/load_flow/models/lines/parameters.py Outdated Show resolved Hide resolved
@benoit9126 benoit9126 merged commit b261479 into develop Aug 25, 2023
4 checks passed
@benoit9126 benoit9126 deleted the line-parameters branch August 25, 2023 15:45
@benoit9126 benoit9126 mentioned this pull request Aug 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alihamdan alihamdan alihamdan approved these changes

Assignees

@benoit9126 benoit9126

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DOC: LineParameters alternative constructors
2 participants
@benoit9126 @alihamdan