Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up tests by replacing timed wait with event handlers #97

Closed
Gjum opened this issue Apr 7, 2023 · 4 comments · Fixed by #170
Closed

Speed up tests by replacing timed wait with event handlers #97

Gjum opened this issue Apr 7, 2023 · 4 comments · Fixed by #170

Comments

@Gjum
Copy link
Collaborator

Gjum commented Apr 7, 2023

E.g., instead of waiting a fixed 2 seconds to join the local server, just wait for the position packet or similar.
@Gjum Gjum changed the title Speed up tests by removing timed wait with event handlers Speed up tests by replacing timed wait with event handlers Apr 7, 2023
@grepsedawk
Copy link
Collaborator

join_game shouldn't yield until we're in a start state

@grepsedawk
Copy link
Collaborator

Also we don't need to dig down 10 blocks, it could be ~3 and it would likely be just as valuable

@Gjum
Copy link
Collaborator Author

Gjum commented Apr 8, 2023

join_game shouldn't yield until we're in a start state

Which "ready event" are we looking for? blocks loaded? position reset? inventory loaded?

@grepsedawk
Copy link
Collaborator

Could wait for all

grepsedawk added a commit that referenced this issue Aug 1, 2023
@grepsedawk
Rewrite client to use a global tick loop
564a8f7 
Only digging, use hand, change hotbar slot, and physics are part of this
loops sofar

Speed up the specs greatly using event emitter callbacks

Add apple to eating

Fix a ton of random anti-cheat issues

Fix a few inventory desync issues

Resolves #98
Resolves #97
grepsedawk added a commit that referenced this issue Aug 1, 2023
@grepsedawk
Rewrite client to use a global tick loop
4f248c6 
Only digging, use hand, change hotbar slot, and physics are part of this
loops sofar

Speed up the specs greatly using event emitter callbacks

Add apple to eating

Fix a ton of random anti-cheat issues

Fix a few inventory desync issues

Resolves #98
Resolves #97
@grepsedawk grepsedawk mentioned this issue Aug 1, 2023
Merged
grepsedawk added a commit that referenced this issue Aug 2, 2023
@grepsedawk
Rewrite client to use a global tick loop
683de94 
Only digging, use hand, change hotbar slot, and physics are part of this
loops sofar

Speed up the specs greatly using event emitter callbacks

Add apple to eating

Fix a ton of random anti-cheat issues

Fix a few inventory desync issues

Fixes the occasional eating problems

Resolves #98
Resolves #97
grepsedawk added a commit that referenced this issue Aug 2, 2023
@grepsedawk
Rewrite client to use a global tick loop
5f6adb1 
Only digging, use hand, change hotbar slot, and physics are part of this
loops sofar

Speed up the specs greatly using event emitter callbacks

Add apple to eating

Fix a ton of random anti-cheat issues

Fix a few inventory desync issues

Fixes the occasional eating problems

Resolves #98
Resolves #97
grepsedawk added a commit that referenced this issue Aug 2, 2023
@grepsedawk
Rewrite client to use a global tick loop
22aa285 
Only digging, use hand, change hotbar slot, and physics are part of this
loops sofar

Speed up the specs greatly using event emitter callbacks

Add apple to eating

Fix a ton of random anti-cheat issues

Fix a few inventory desync issues

Fixes the occasional eating problems

Resolves #98
Resolves #97
grepsedawk added a commit that referenced this issue Aug 2, 2023
@grepsedawk
Rewrite client to use a global tick loop
aa06fe9 
Only digging, use hand, change hotbar slot, and physics are part of this
loops sofar

Speed up the specs greatly using event emitter callbacks

Add apple to eating

Fix a ton of random anti-cheat issues

Fix a few inventory desync issues

Fixes the occasional eating problems

Resolves #98
Resolves #97
grepsedawk added a commit that referenced this issue Aug 11, 2023
@grepsedawk
Rewrite client to use a global tick loop
574c414 
Only digging, use hand, change hotbar slot, and physics are part of this
loops sofar

Speed up the specs greatly using event emitter callbacks

Add apple to eating

Fix a ton of random anti-cheat issues

Fix a few inventory desync issues

Fixes the occasional eating problems

Resolves #98
Resolves #97
grepsedawk added a commit that referenced this issue Aug 11, 2023
@grepsedawk
Rewrite client to use a global tick loop
f568416 
Only digging, use hand, change hotbar slot, and physics are part of this
loops sofar

Speed up the specs greatly using event emitter callbacks

Add apple to eating

Fix a ton of random anti-cheat issues

Fix a few inventory desync issues

Fixes the occasional eating problems

Resolves #98
Resolves #97
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move everything to a tick loop RosegoldMC/rosegold.cr
2 participants
@Gjum @grepsedawk