Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed JSON response example in Tournament Search #46

Merged
merged 3 commits into from
Jul 26, 2018
Merged

Fixed JSON response example in Tournament Search #46

merged 3 commits into from
Jul 26, 2018

Conversation

jegfish
Copy link

@jegfish jegfish commented Jul 26, 2018

resolves #47

Copy link
Contributor

@fourjr fourjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't the only breaking change recently, refer below:

@jegfish
Copy link
Author

jegfish commented Jul 26, 2018

😅 I can't believe I forgot to make the changes I mentioned myself.
Just committed them, everything should be good to go.

Copy link
Contributor

@fourjr fourjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other endpoints like 1k, open, /tournament might also need updating :(

@jegfish
Copy link
Author

jegfish commented Jul 26, 2018

I have all the tournament endpoints finished, would appreciate a double check.

There was a special case for Popular Tournaments. The data is not wrong, it is incomplete. However this appears to be intended to not take up too much space.

[
    {
        "popularity": {
            "hits": "35",
            "hitsPerDayAvg": 11.67
        },
        "tag": "...",
    },
    {}
]

The same lack of data is used in the other Popular endpoints. Might be good to complete this data, but it's not really relevant to this PR.

@fourjr fourjr merged commit bca30c7 into RoyaleAPI:master Jul 26, 2018
@fourjr
Copy link
Contributor

fourjr commented Jul 26, 2018

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Tournaments endpoint not returning type
2 participants