-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add query generator #9
Conversation
Thanks! Let me go through the commits, consolidate them, add a README, and I'll merge. |
BTW By what name may I credit you in the README? 😉 |
@RubenVerborgh Ah, totally forgot about that part 😄 |
Could you please fix these issues?
I'll then make some further edits before merging. |
Okay, will rebase to make it look nice. |
…from passing)
okay, all fixed, rebased and pushed. |
Thanks, will review in-depth and then merge. Excellent work! |
@RubenVerborgh any updates? 😄 |
Still traveling; on to-do list. |
okay, cool. please, ping me once it's merged :) |
FYI I'm still working on this, but some things are taking a bit more time than expected. Some code, while working as intended, does not accurately reflect functionality. For instance: var varSymbols = ['?', '_:', '"', '*']; // symbols presence of which means that string is SPARQL variable So sorry for the delay, but I'm taking quality control very seriously 😉 |
sounds good! 👍 |
7d22908
to
ef0c504
Compare
Thanks for implementing this. Merged in master! |
had a quick look - seems to be good. |
Thx! Will document interface and release a version one of these days. |
cool! 😸 |
Released as v1.1.0. |
awesome! now to update the deps.. :D |
Adds query generator for #4