Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query generator #9

Closed
wants to merge 10 commits into from
Closed

Add query generator #9

wants to merge 10 commits into from

Conversation

yamalight
Copy link
Contributor

Adds query generator for #4

@RubenVerborgh
Copy link
Owner

Thanks! Let me go through the commits, consolidate them, add a README, and I'll merge.

@RubenVerborgh
Copy link
Owner

BTW By what name may I credit you in the README? 😉

@yamalight
Copy link
Contributor Author

@RubenVerborgh Ah, totally forgot about that part 😄
Tim Ermilov <yamalight@gmail.com>

@RubenVerborgh
Copy link
Owner

Could you please fix these issues?

  • Looks like there's a bad merge: all commits appear twice. I'd suggest rebasing on the current master branch, ensuring that all commits appear once
  • Running npm test only runs the generator tests, not the parser tests (for some reason I can't immediately figure out).

I'll then make some further edits before merging.

@yamalight
Copy link
Contributor Author

Okay, will rebase to make it look nice.
And yes, will fix the test, forgot to remove .only() part, being silly >_>

@yamalight
Copy link
Contributor Author

okay, all fixed, rebased and pushed.

@RubenVerborgh
Copy link
Owner

Thanks, will review in-depth and then merge. Excellent work!

@yamalight
Copy link
Contributor Author

@RubenVerborgh any updates? 😄

@RubenVerborgh
Copy link
Owner

Still traveling; on to-do list.

@yamalight
Copy link
Contributor Author

okay, cool. please, ping me once it's merged :)

@RubenVerborgh
Copy link
Owner

FYI I'm still working on this, but some things are taking a bit more time than expected. Some code, while working as intended, does not accurately reflect functionality. For instance:

var varSymbols = ['?', '_:', '"', '*']; // symbols presence of which means that string is SPARQL variable

So sorry for the delay, but I'm taking quality control very seriously 😉

@yamalight
Copy link
Contributor Author

sounds good! 👍

@RubenVerborgh
Copy link
Owner

Thanks for implementing this. Merged in master!
Please let me know if everything looks alright to you; if so, I'll do a new release.

@yamalight
Copy link
Contributor Author

had a quick look - seems to be good.
that's some nice work on improvements! :)

@RubenVerborgh
Copy link
Owner

Thx! Will document interface and release a version one of these days.

@yamalight
Copy link
Contributor Author

cool! 😸

@RubenVerborgh
Copy link
Owner

Released as v1.1.0.

@yamalight
Copy link
Contributor Author

awesome! now to update the deps.. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants