Fix SEGV on 32-bit architectures #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes RubyCrypto#1 Previously lengths were passed to functions as `int` but the function prototype requires `long long`. 64-bit ruby was fine with this, but 32 bit barfed.
|
That's working now, except for on rbx. I'm assuming specifying the correct type as per the prototype won't break on 64-bit. The rbx error is somewhere in ffi, before it even reaches any code I wrote. But tracking that down is a task for later. |
|
This shouldn't be an issue, as it was closed over a year ago. But there it is. ffi/ffi#127 |
|
Checked this patch also runs fine locally. Could the rbx failure be a bundler issue, where the bundler paths override the internal FFI implementation? |
|
rbx failure is an out-of-date build on Travis, from what I understand. I get this same failure on other projects using FFI. |
tarcieri
added a commit
that referenced
this pull request
Jan 21, 2013
Fix SEGV on 32-bit architectures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1
Previously lengths were passed to functions as
intbut the function prototype requireslong long. 64-bit ruby was fine with this, but 32 bit barfed.Lets see if Travis is happy ...