Fix method name to convert binary to hex in Serializable module #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
facepalm @namelessjon it pains me we don't have test coverage for this 😦 Burned again! |
tarcieri
added a commit
that referenced
this pull request
Sep 11, 2013
Fix method name to convert binary to hex in Serializable module
|
Yes, much 😦 . Let's get 100% test coverage, and then keep it that way. Though apparently this module is 100% covered. Perhaps some kind of mutation testing? |
|
What about using mutant? I can provide help setting it up if need be. I really think that a cryptographic lib like that would benefit from 100% mutation test coverage, and it's actually not that hard to achieve. I might be able to help out with writing a few specs too. |
|
That's what I was considering, yeah. |
|
Regardless of what coverage tools are reporting that's clearly not getting exercised by the suite. I'll see if I can put together some shared specs for Serializable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Util.bytes2hexdoesn't exits, it's calledUtil.bin2hex.