Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos and remove double entry from CHANGELOG.md #107

Conversation

nitsas
Copy link
Contributor

@nitsas nitsas commented Oct 5, 2017

Removed entry is also present earlier as:

Fix issue where parsing a Money object resulted in a Money object
with its currency set to Money.default_currency, rather than
the currency that it was sent in as.

Both entries refer to the fix in 4de6016. The longer version was introduced back then; the shorter one later, in 4aa7caf (v1.5.0 release). I kept the longer version because it describes the issue too. If you prefer the other one I can change this.

Removed entry is also present earlier as:

> Fix issue where parsing a Money object resulted in a Money object
> with its currency set to `Money.default_currency`, rather than
> the currency that it was sent in as.
@coveralls
Copy link

coveralls commented Oct 5, 2017

Coverage Status

Coverage remained the same at 98.963% when pulling 0b15158 on nitsas:fix_typos_and_remove_double_entry_from_changelog into 904737b on RubyMoney:master.

Copy link
Contributor

@antstorm antstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@antstorm antstorm merged commit 32e6a61 into RubyMoney:master Oct 10, 2017
antstorm pushed a commit to antstorm/monetize that referenced this pull request Nov 5, 2017
Removed entry is also present earlier as:

> Fix issue where parsing a Money object resulted in a Money object
> with its currency set to `Money.default_currency`, rather than
> the currency that it was sent in as.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants