Ensure coerce only applies to multiplication #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RubyMoney/money-rails-devs any thoughts on this one? |
|
Related to #405? |
|
@ct-clearhaus yeah, didn't notice that. Will read through that PR and see what needs to be changed to merge it. |
|
👍 |
|
status? |
|
|
||
| def +(other) raise TypeError; end | ||
| def -(other) raise TypeError; end | ||
| def /(other) raise TypeError; end |
There was a problem hiding this comment.
I would say division is valid for coercion as you would not divide $10 by $2, but you would divide $10 by 2.
There was a problem hiding this comment.
The % modulo operator should also be included with the same treatment as division.
|
I think this is a great improvement and feel |
semmons99
added a commit
that referenced
this pull request
Sep 29, 2015
Ensure coerce only applies to multiplication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resurrected @semmons99's commit from last year, that properly handles coercion for non-Money objects. Raises a TypeError in cases like 0 - Money.new(1), where it otherwise produces a wrong result.
Here's some discussion around this — RubyMoney/money-rails#343
P.S. reopened a PR because of the failing TravisCI build. There's an issue with a "thread safe" test that's failing randomly.