Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

migrating to python 3 #312

Merged
merged 2 commits into from
Oct 10, 2020
Merged

migrating to python 3 #312

merged 2 commits into from
Oct 10, 2020

Conversation

rsoorajs
Copy link
Contributor

@rsoorajs rsoorajs commented Oct 9, 2020 •
edited
Loading

python2 is going to obsolete soon.so a small change to use python3 in heroku

@rsoorajs
migrating to python 3
18be22e 
python2 is going obsolete soon.so a small change to use python3 in heroku
Rudloff
Rudloff suggested changes Oct 9, 2020
View reviewed changes
Copy link
Owner

@Rudloff Rudloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
It seems to run correctly.

However, Heroku suggests using 3.8.6:

remote:  !     Python has released a security update! Please consider upgrading to python-3.8.6

@Rudloff Rudloff changed the base branch from master to develop October 9, 2020 21:38
rsoorajs
rsoorajs commented Oct 10, 2020
View reviewed changes
Copy link
Contributor Author

@rsoorajs rsoorajs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed python version

@Rudloff Rudloff merged commit 79ec6ae into Rudloff:develop Oct 10, 2020
@Rudloff Rudloff mentioned this pull request Oct 17, 2020
Closed
@Rudloff Rudloff linked an issue Oct 17, 2020 that may be closed by this pull request
Use Python 3 on Heroku #289
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Rudloff Rudloff Rudloff requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Python 3 on Heroku
2 participants
@rsoorajs @Rudloff