Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pruning an offline player sometimes fails #50

Closed
Tracked by #57
Rumsfield opened this issue May 4, 2023 · 1 comment · Fixed by #76
Closed
Tracked by #57

Pruning an offline player sometimes fails #50

Rumsfield opened this issue May 4, 2023 · 1 comment · Fixed by #76
Assignees
Labels
bug Something isn't working

Comments

@Rumsfield
Copy link
Owner

Context is that there's a kingdom with a master and an officer. The master exceeds the offline timeout and attempts to be pruned. During the forced exile, the officer was set as the new master, and the old master's UUID was removed from the kingdom's membership list. However, it appears that the old master's kingdom was not updated to Barbarians, and their isBarbarian flag remains false. This data is not flushed to the database either.

On subsequent offline timeout pruning intervals, the old master is identified as not a Barbarian at attempts to force exile again, but it always errors out because the player is not a member of their kingdom, error shown below:

image

Things to investigate:

  • How did the offline player get into this state?
  • Is there a logic error on the first time they were pruned, where the officer was successfully given master, and that somehow upset the membership accounting?
  • Maybe its fine if the membership doesn't exist, try adjusting the error conditions.
@Rumsfield Rumsfield added bug Something isn't working patch Public patch labels May 4, 2023
@Rumsfield
Copy link
Owner Author

More info is that many other kingdoms (most without any officers probably) were successfully removed when their master was pruned for offline timeout.

@Rumsfield Rumsfield removed the patch Public patch label May 12, 2023
@Rumsfield Rumsfield mentioned this issue May 13, 2023
24 tasks
Rumsfield added a commit that referenced this issue May 14, 2023
@Rumsfield Rumsfield self-assigned this May 21, 2023
Rumsfield added a commit that referenced this issue May 27, 2023
* Updated version #57

* Added success notice for kingdom transfer #57

* Updated kingdom membership logic #57 #50

* Update border particle update logic #57

* Tested various bug fixes #57

* Added ruin api methods, cleaned messages #57 #73

* Fixed placeholder NPE, spam #57 #56

* Added player kingdom placeholders #57 #56

* Updated protections for peaceful kingdoms #57

* Updated admin flag command args and auto-complete #57

* Updated javadoc #57

* Removed doc for gitignore #57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant